From ad8bc05877a87ec30aab30b0394852e91e90b81d Mon Sep 17 00:00:00 2001 From: sarahcaseybot Date: Tue, 26 Jan 2021 20:10:41 -0500 Subject: [PATCH] Fix typo in header name in Client Certificate Provider (#946) * Fix typo in header name * fix test --- core/src/main/java/google/registry/flows/TlsCredentials.java | 2 +- .../test/java/google/registry/flows/TlsCredentialsTest.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/google/registry/flows/TlsCredentials.java b/core/src/main/java/google/registry/flows/TlsCredentials.java index 8fde8bd0b..48f64bdff 100644 --- a/core/src/main/java/google/registry/flows/TlsCredentials.java +++ b/core/src/main/java/google/registry/flows/TlsCredentials.java @@ -289,7 +289,7 @@ public class TlsCredentials implements TransportCredentials { static Optional provideClientCertificate(HttpServletRequest req) { // Note: This header is actually required, we just want to handle its absence explicitly // by throwing an EPP exception rather than a generic Bad Request exception. - return extractOptionalHeader(req, "X-SSL-Full_Certificate"); + return extractOptionalHeader(req, "X-SSL-Full-Certificate"); } @Provides diff --git a/core/src/test/java/google/registry/flows/TlsCredentialsTest.java b/core/src/test/java/google/registry/flows/TlsCredentialsTest.java index d3e77838a..e0d480f20 100644 --- a/core/src/test/java/google/registry/flows/TlsCredentialsTest.java +++ b/core/src/test/java/google/registry/flows/TlsCredentialsTest.java @@ -118,10 +118,11 @@ final class TlsCredentialsTest { tls.validateCertificate(Registrar.loadByClientId("TheRegistrar").get()); } + @Test void testProvideClientCertificate() { HttpServletRequest req = mock(HttpServletRequest.class); when(req.getHeader("X-SSL-Full-Certificate")).thenReturn("data"); - assertThat(TlsCredentials.EppTlsModule.provideClientCertificate(req)).isEqualTo("data"); + assertThat(TlsCredentials.EppTlsModule.provideClientCertificate(req)).hasValue("data"); } @Test