zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-29 17:00:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Better handle syncing contacts when creating RegistrarContacts

Browse source 
This also adds a test that should've been there already.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=149583500
This commit is contained in:
mcilwain 2017-03-08 14:29:10 -08:00 • committed by Ben McIlwain
parent 27b9244126
commit ad840ad4d6
2 changed files with 48 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

9
java/google/registry/tools/RegistrarContactCommand.java
View file

@ -54,8 +54,6 @@ import javax.annotation.Nullable;
commandDescription = "Create/read/update/delete the various contact lists for a Registrar.")
final class RegistrarContactCommand extends MutatingCommand {
private enum Mode { LIST, CREATE, UPDATE, DELETE }
@Parameter(
description = "Client identifier of the registrar account.",
required = true)
@ -131,6 +129,11 @@ final class RegistrarContactCommand extends MutatingCommand {
validateWith = PathParameter.OutputFile.class)
private Path output = Paths.get("/dev/stdout");
private enum Mode { LIST, CREATE, UPDATE, DELETE }
private static final ImmutableSet<Mode> MODES_REQUIRING_CONTACT_SYNC =
ImmutableSet.of(Mode.CREATE, Mode.UPDATE, Mode.DELETE);
@Nullable
private Set<RegistrarContact.Type> contactTypes;
@ -178,7 +181,7 @@ final class RegistrarContactCommand extends MutatingCommand {
default:
throw new AssertionError();
}
if (mode == Mode.CREATE || mode == Mode.UPDATE || mode == Mode.DELETE) {
if (MODES_REQUIRING_CONTACT_SYNC.contains(mode)) {
stageEntityChange(registrar, registrar.asBuilder().setContactsRequireSyncing(true).build());
}
}