zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-29 07:43:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

make transitionId a required parameter (#1083)

Browse source
This commit is contained in:
Rachel Guan 2021-04-15 10:42:15 -04:00 • committed by GitHub
parent a609928a16
commit ad79d59cd9
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
core/src/main/java/google/registry/tools/SetDatabaseTransitionScheduleCommand.java
View file

@ -43,6 +43,7 @@ public class SetDatabaseTransitionScheduleCommand extends MutatingCommand {
@Parameter(
names = "--transition_id",
required = true,
description = "Transition id string for the schedule being updated")
private TransitionId transitionId;

11
core/src/test/java/google/registry/tools/SetDatabaseTransitionScheduleCommandTest.java
View file

@ -20,7 +20,9 @@ import static google.registry.model.ofy.ObjectifyService.ofy;
import static google.registry.persistence.transaction.TransactionManagerFactory.ofyTm;
import static google.registry.testing.DatabaseHelper.persistResource;
import static google.registry.util.DateTimeUtils.START_OF_TIME;
import static org.junit.jupiter.api.Assertions.assertThrows;
import com.beust.jcommander.ParameterException;
import com.google.common.collect.ImmutableSortedMap;
import com.googlecode.objectify.Key;
import google.registry.model.common.DatabaseTransitionSchedule;
@ -45,6 +47,15 @@ public class SetDatabaseTransitionScheduleCommandTest
fakeClock.setTo(DateTime.parse("2020-12-01T00:00:00Z"));
}
@Test
void testFailure_noTransitionId() throws Exception {
ParameterException thrown =
assertThrows(
ParameterException.class,
() -> runCommandForced("--transition_schedule=2021-04-14T00:00:00.000Z=DATASTORE"));
assertThat(thrown).hasMessageThat().contains("--transition_id");
}
@Test
void testSuccess_currentScheduleIsEmpty() throws Exception {
assertThat(ofy().load().key(key).now()).isNull();