zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-28 12:31:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use Docker Java API to manage container for WebDriver

Browse source 
Previously we had a few customized Gradle build task to manage
the Docker container for provisioning browser and ChromeDriverService
used by WebDriver tests. This CL changed to use a java library
from testcontainers.org to achieve the same purpose. The main
benefit of it is that we can expect to run the WebDriver tests
from IDE going forward.

Also, this CL refactored the structure of WebDriver related classes
to have JUnit rule to manage the lifecycle of WebDriver instance,
this is also compatible with the API from testcontainers library.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=241539861
This commit is contained in:
shicong 2019-04-02 09:07:55 -07:00 • committed by jianglai
parent 5470414e48
commit ac74ad3088
29 changed files with 376 additions and 177 deletions
Download patch file Download diff file Expand all files Collapse all files

5
javatests/google/registry/webdriver/RegistrarConsoleWebTest.java
View file

@ -29,7 +29,6 @@ import google.registry.model.registrar.RegistrarContact;
import google.registry.module.frontend.FrontendServlet;
import google.registry.server.RegistryTestServer;
import google.registry.testing.AppEngineRule;
import google.registry.webdriver.RepeatableRunner.AttemptNumber;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.Timeout;
@ -38,7 +37,7 @@ import org.openqa.selenium.By;
/** WebDriver tests for Registrar Console UI. */
@RunWith(RepeatableRunner.class)
public class RegistrarConsoleWebTest {
public class RegistrarConsoleWebTest extends WebDriverTestCase {
@Rule
public final AppEngineRule appEngine = AppEngineRule.builder()
@ -59,8 +58,6 @@ public class RegistrarConsoleWebTest {
.setEmail("Marla.Singer@google.com")
.build();
private final AttemptNumber attemptNumber = new AttemptNumber();
@Rule public final WebDriverRule driver = new WebDriverRule(attemptNumber);
@Rule public final Timeout deathClock = new Timeout(60000);