zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-25 12:08:36 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add RetryingTest annotation to flaky RDE test (#1306)

Browse source 
I'm not sure why this test is failing. It's failing saying that the
listObjects call is failing to include
"soy_2000-01-01_thin_S1_R1.xml.ghostryde" in the results, however the
verifyFiles method that we call right beforehand verifies that file and
its contents
This commit is contained in:
gbrodman 2021-09-03 07:39:55 -06:00 • committed by GitHub
parent 98f0b62dc3
commit aab04f9b77
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
core/src/test/java/google/registry/beam/rde/RdePipelineTest.java
View file

@ -91,6 +91,7 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junitpioneer.jupiter.RetryingTest;
/** Unit tests for {@link RdePipeline}. */
public class RdePipelineTest {
@ -288,7 +289,8 @@ public class RdePipelineTest {
pipeline.run().waitUntilFinish();
}
@Test
// The GCS folder listing can be a bit flaky, so retry if necessary
@RetryingTest(4)
void testSuccess_persistData() throws Exception {
PendingDeposit brdaKey =
PendingDeposit.create("soy", now, THIN, CursorType.BRDA, Duration.standardDays(1));
@ -314,7 +316,8 @@ public class RdePipelineTest {
assertThat(loadRevision(now, FULL)).isEqualTo(1);
}
@Test
// The GCS folder listing can be a bit flaky, so retry if necessary
@RetryingTest(4)
void testSuccess_persistData_manual() throws Exception {
PendingDeposit brdaKey = PendingDeposit.createInManualOperation("soy", now, THIN, "test/", 0);
PendingDeposit rdeKey = PendingDeposit.createInManualOperation("soy", now, FULL, "test/", 0);