zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove the scrap AllocationToken command and OnLoad method

Browse source 
I have resaved all the tokens and verified in BigQuery that there are no
remaining null tokenTypes.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247425132
This commit is contained in:
gbrodman 2019-05-09 07:58:45 -07:00 • committed by jianglai
parent 5bb93e9e4a
commit aa83472393
3 changed files with 0 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

9
java/google/registry/model/domain/token/AllocationToken.java
View file

@ -35,7 +35,6 @@ import com.googlecode.objectify.annotation.Entity;
import com.googlecode.objectify.annotation.Id;
import com.googlecode.objectify.annotation.Index;
import com.googlecode.objectify.annotation.Mapify;
import com.googlecode.objectify.annotation.OnLoad;
import google.registry.model.BackupGroupRoot;
import google.registry.model.Buildable;
import google.registry.model.CreateAutoTimestamp;
@ -118,14 +117,6 @@ public class AllocationToken extends BackupGroupRoot implements Buildable {
TimedTransitionProperty<TokenStatus, TokenStatusTransition> tokenStatusTransitions =
TimedTransitionProperty.forMapify(NOT_STARTED, TokenStatusTransition.class);
// TODO(b/130301183): Remove this after loading/saving all token entities
@OnLoad
void onLoad() {
if (tokenType == null) {
tokenType = TokenType.SINGLE_USE;
}
}
/**
* A transition to a given token status at a specific time, for use in a TimedTransitionProperty.
*

2
java/google/registry/tools/RegistryTool.java
View file

@ -17,7 +17,6 @@ package google.registry.tools;
import com.google.common.collect.ImmutableMap;
import google.registry.tools.javascrap.PopulateNullRegistrarFieldsCommand;
import google.registry.tools.javascrap.RemoveIpAddressCommand;
import google.registry.tools.javascrap.ResaveAllocationTokensCommand;
/** Container class to create and run remote commands against a Datastore instance. */
public final class RegistryTool {
@ -97,7 +96,6 @@ public final class RegistryTool {
.put("registrar_contact", RegistrarContactCommand.class)
.put("remove_ip_address", RemoveIpAddressCommand.class)
.put("renew_domain", RenewDomainCommand.class)
.put("resave_allocation_tokens", ResaveAllocationTokensCommand.class)
.put("resave_entities", ResaveEntitiesCommand.class)
.put("resave_environment_entities", ResaveEnvironmentEntitiesCommand.class)
.put("resave_epp_resource", ResaveEppResourceCommand.class)

43
java/google/registry/tools/javascrap/ResaveAllocationTokensCommand.java
View file

@ -1,43 +0,0 @@
// Copyright 2019 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.tools.javascrap;
import static com.google.common.collect.Lists.partition;
import static google.registry.model.ofy.ObjectifyService.ofy;
import com.beust.jcommander.Parameters;
import com.googlecode.objectify.Key;
import google.registry.model.domain.token.AllocationToken;
import google.registry.tools.MutatingCommand;
import java.util.List;
/** Scrap tool to load and save all {@link AllocationToken}s to populate on-load attributes. */
@Parameters(commandDescription = "Load and resave all allocation tokens")
public final class ResaveAllocationTokensCommand extends MutatingCommand {
private static final int BATCH_SIZE = 20;
@Override
protected void init() {
List<Key<AllocationToken>> tokenKeys = ofy().load().type(AllocationToken.class).keys().list();
for (List<Key<AllocationToken>> partitionedKeys : partition(tokenKeys, BATCH_SIZE)) {
for (Key<AllocationToken> key : partitionedKeys) {
AllocationToken token = ofy().load().key(key).now();
stageEntityChange(token, token);
}
flushTransaction();
}
}
}