mirror of
https://github.com/google/nomulus.git
synced 2025-05-12 22:38:16 +02:00
Add a log statement at the very end of our code
Having a log at the very begining of "our" code helped us find issues with App-Engine's dispatcher, where we could clearly see in the logs that "our" code started many seconds after the request came in. We now suspect there is something similar going on after the end of "our" code - where the reply is sent back many seconds after our code finished running. To make sure - we add a log statement at the very last line of "our" code, so we know exactly when it ended. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219309962
This commit is contained in:
parent
a76300f76c
commit
a45d3d3bc7
7 changed files with 48 additions and 5 deletions
|
@ -18,6 +18,7 @@ import com.google.appengine.api.LifecycleManager;
|
|||
import com.google.common.flogger.FluentLogger;
|
||||
import com.google.monitoring.metrics.MetricReporter;
|
||||
import dagger.Lazy;
|
||||
import google.registry.util.SystemClock;
|
||||
import java.io.IOException;
|
||||
import java.security.Security;
|
||||
import java.util.concurrent.TimeUnit;
|
||||
|
@ -26,6 +27,7 @@ import javax.servlet.http.HttpServlet;
|
|||
import javax.servlet.http.HttpServletRequest;
|
||||
import javax.servlet.http.HttpServletResponse;
|
||||
import org.bouncycastle.jce.provider.BouncyCastleProvider;
|
||||
import org.joda.time.DateTime;
|
||||
|
||||
/** Servlet that should handle all requests to our "default" App Engine module. */
|
||||
public final class FrontendServlet extends HttpServlet {
|
||||
|
@ -34,6 +36,7 @@ public final class FrontendServlet extends HttpServlet {
|
|||
private static final FrontendRequestHandler requestHandler = component.requestHandler();
|
||||
private static final Lazy<MetricReporter> metricReporter = component.metricReporter();
|
||||
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
|
||||
private static final SystemClock clock = new SystemClock();
|
||||
|
||||
@Override
|
||||
public void init() {
|
||||
|
@ -63,6 +66,13 @@ public final class FrontendServlet extends HttpServlet {
|
|||
@Override
|
||||
public void service(HttpServletRequest req, HttpServletResponse rsp) throws IOException {
|
||||
logger.atInfo().log("Received frontend request");
|
||||
requestHandler.handleRequest(req, rsp);
|
||||
DateTime startTime = clock.nowUtc();
|
||||
try {
|
||||
requestHandler.handleRequest(req, rsp);
|
||||
} finally {
|
||||
logger.atInfo().log(
|
||||
"Finished frontend request. Latency: %.3fs",
|
||||
(clock.nowUtc().getMillis() - startTime.getMillis()) / 1000d);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue