zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-21 03:39:36 +02:00
Code Issues Projects Releases Packages Wiki Activity

Hide the edit/add buttons for fields the user can't update

Browse source 
Currently the /registrar-settings backend endpoint will fail to update any
OWNER fields that a non-OWNER tries to change.

However, the front-end (soy, js) still allow non-OWNERs to try and change
these fields (there's the "edit" or "add" button, and it only fails when you try to "save")

This CL changes the front-end to remove the ability for non-OWNERs to even try
and change these fields. However, it will still let them *view* these fields as
it has interesting and important information.

-------------------------------

In addition - it changes the webdriver tests to include the "edit buttons". Those were never tested before, and now we will test to see if they are indeed displayed or not.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223845883
This commit is contained in:
guyben 2018-12-03 12:51:37 -08:00 • committed by jianglai
parent f980a25b32
commit a3a60075a0
19 changed files with 118 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

10
javatests/google/registry/ui/js/registrar/console_test_util.js
View file

@ -61,6 +61,7 @@ registry.registrar.ConsoleTestUtil.renderConsoleMain = function(
username: args.username || 'jart',
logoutUrl: args.logoutUrl || 'https://logout.url.com',
isAdmin: !!args.isAdmin,
isOwner: !!args.isOwner,
clientId: args.clientId || 'ignore',
allClientIds: args.allClientIds || ['clientId1', 'clientId2'],
logoFilename: args.logoFilename || 'logo.png',
@ -89,6 +90,15 @@ registry.registrar.ConsoleTestUtil.visit = function(
opt_args.clientId = opt_args.clientId || 'dummyRegistrarId';
opt_args.xsrfToken = opt_args.xsrfToken || 'dummyXsrfToken';
opt_args.isAdmin = !!opt_args.isAdmin;
// set the default isOwner to be the opposite of isAdmin.
// That way, if we don't explicitly state them both we get what we'd expect:
// {} -> OWNER (the "regular" case of a visitor to the console)
// {isOwner:true} -> OWNER
// {isAdmin:true} -> ADMIN (the "regular" case of an admin visitor)
// {isOwner:true, isAdmin:true} -> OWNER + ADMIN together
if (opt_args.isOwner === undefined) {
opt_args.isOwner = !opt_args.isAdmin;
}
if (opt_args.isEppLoggedIn === undefined) {
opt_args.isEppLoggedIn = true;
}