Hide the edit/add buttons for fields the user can't update

Currently the /registrar-settings backend endpoint will fail to update any
OWNER fields that a non-OWNER tries to change.

However, the front-end (soy, js) still allow non-OWNERs to try and change
these fields (there's the "edit" or "add" button, and it only fails when you try to "save")

This CL changes the front-end to remove the ability for non-OWNERs to even try
and change these fields. However, it will still let them *view* these fields as
it has interesting and important information.

-------------------------------

In addition - it changes the webdriver tests to include the "edit buttons". Those were never tested before, and now we will test to see if they are indeed displayed or not.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223845883
This commit is contained in:
guyben 2018-12-03 12:51:37 -08:00 committed by jianglai
parent f980a25b32
commit a3a60075a0
19 changed files with 118 additions and 74 deletions

View file

@ -102,27 +102,25 @@
/** Appbar add/back, edit/cancel appbar. */
{template .appbarButtons}
<div id="reg-app-buttons" class="{css('kd-buttonbar')} {css('left')}">
<button id="reg-app-btn-add"
<button id="reg-app-btn-add"
type="button"
class="{css('kd-button')} {css('kd-button-submit')} {css('hidden')}">
Add</button>
<div id="reg-app-btns-edit" class="{css('hidden')}">
<button id="reg-app-btn-edit"
type="button"
class="{css('kd-button')} {css('kd-button-submit')} {css('hidden')}">
Add</button>
<div id="reg-app-btns-edit" class="{css('hidden')}">
<button id="reg-app-btn-edit"
type="button"
class="{css('kd-button')} {css('kd-button-submit')}">
Edit</button>
<button id="reg-app-btn-back" type="button" class="{css('kd-button')}">
Back</button>
</div>
<div id="reg-app-btns-save" class="{css('hidden')}">
<button id="reg-app-btn-save"
type="button"
class="{css('kd-button')} {css('kd-button-submit')}">
Save</button>
<button id="reg-app-btn-cancel" type="button" class="{css('kd-button')}">
Cancel</button>
</div>
class="{css('kd-button')} {css('kd-button-submit')}">
Edit</button>
<button id="reg-app-btn-back" type="button" class="{css('kd-button')}">
Back</button>
</div>
<div id="reg-app-btns-save" class="{css('hidden')}">
<button id="reg-app-btn-save"
type="button"
class="{css('kd-button')} {css('kd-button-submit')}">
Save</button>
<button id="reg-app-btn-cancel" type="button" class="{css('kd-button')}">
Cancel</button>
</div>
{/template}