zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-27 06:44:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Hide the edit/add buttons for fields the user can't update

Browse source 
Currently the /registrar-settings backend endpoint will fail to update any
OWNER fields that a non-OWNER tries to change.

However, the front-end (soy, js) still allow non-OWNERs to try and change
these fields (there's the "edit" or "add" button, and it only fails when you try to "save")

This CL changes the front-end to remove the ability for non-OWNERs to even try
and change these fields. However, it will still let them *view* these fields as
it has interesting and important information.

-------------------------------

In addition - it changes the webdriver tests to include the "edit buttons". Those were never tested before, and now we will test to see if they are indeed displayed or not.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223845883
This commit is contained in:
guyben 2018-12-03 12:51:37 -08:00 • committed by jianglai
parent f980a25b32
commit a3a60075a0
19 changed files with 118 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

24
java/google/registry/ui/css/kd_components.css
View file

@ -1244,12 +1244,12 @@ li.kd-labellistitem a.kd-label-blue {
Component: App bars
------------------------------------------------------------------*/
.kd-appbar {
position:relative;
position: relative;
padding: 21px 0;
border-bottom: 1px solid #ebebeb;
height: 29px;
z-index:20;
background:#fff;
height: 66px;
z-index: 20;
background: #fff;
}
.kd-appbar .kd-appname {
width: 160px;
@ -1263,6 +1263,22 @@ Component: App bars
color: #666;
white-space:nowrap;
}
.kd-appbar .kd-description {
height: 29px;
font-size: 20px;
font-weight: normal;
line-height: 29px;
padding-bottom: 8px;
color: #666;
white-space:nowrap;
}
.kd-appbar .kd-description .kd-value {
color: black;
font-weight: bold;
}
.kd-appbar .kd-description form {
display: inline;
}
.kd-appbar .kd-appname a { color: #666; cursor:pointer; }
#stickers .kd-appbar .kd-buttonbar {
margin-bottom: 0;

13
java/google/registry/ui/css/registry.css
View file

@ -196,13 +196,10 @@ li.kd-menulistitem {
}
.kd-appbar {
padding: 0.75em 0;
}
#reg-app-buttons {
/* Same as in reg-content below. Lines the left edge of the
appbuttons and content area with the 'R' in Registry. */
/* same as in reg-content below. lines the left edge of the
appbuttons and content area with the 'r' in registry. */
padding-left: 173px;
padding-top: .75em;
}
.kd-content-sidebar {
@ -214,7 +211,7 @@ li.kd-menulistitem {
#reg-nav {
position: fixed;
left: 0;
top: 128px;
top: 136px;
width: 155px;
margin: 0 25px 0 0;
z-index: 3;
@ -261,7 +258,7 @@ li.kd-menulistitem {
#reg-content-and-footer {
position: absolute;
top: 105px;
top: 136px;
left: 173px;
bottom: 0;
width: 100%;