zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-12 22:38:16 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add extensible custom logic to the domain check flow

Browse source 
This also fixes up a hook on the domain create flow custom logic to use a single
parameter, which is the general pattern we want to use going forward. It also
establishes a pattern for custom logic being able to add extensions.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=139362230
This commit is contained in:
mcilwain 2016-11-16 12:12:43 -08:00 • committed by Ben McIlwain
parent fdc8ceb6bb
commit a343648b34
7 changed files with 215 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

34
java/google/registry/flows/custom/DomainCreateFlowCustomLogic.java
View file

@ -18,15 +18,16 @@ import com.google.auto.value.AutoValue;
import com.google.common.net.InternetDomainName;
import google.registry.flows.EppException;
import google.registry.flows.SessionMetadata;
import google.registry.flows.domain.DomainCreateFlow;
import google.registry.model.ImmutableObject;
import google.registry.model.domain.DomainResource;
import google.registry.model.eppinput.EppInput;
import google.registry.model.reporting.HistoryEntry;
/**
* A no-op base class for domain create flow custom logic.
* A no-op base class for {@link DomainCreateFlow} custom logic.
*
* <p>Extend this class and override the hooks to perform custom logic.
* <p>Extend this class and override the hook(s) to perform custom logic.
*/
public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
@ -41,17 +42,16 @@ public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
}
/**
* A hook that runs before new entities are persisted.
* A hook that runs before new entities are persisted, allowing them to be changed.
*
* <p>This takes the new entities as input and returns the actual entities to save. It is
* important to be careful when changing the flow behavior for existing entities, because the core
* logic across many different flows expects the existence of these entities and many of the
* fields on them.
* <p>It returns the actual entity changes that should be persisted to Datastore. It is important
* to be careful when changing the flow behavior for existing entities, because the core logic
* across many different flows expects the existence of these entities and many of the fields on
* them.
*/
@SuppressWarnings("unused")
public EntityChanges beforeSave(BeforeSaveParameters parameters, EntityChanges entityChanges)
throws EppException {
return entityChanges;
public EntityChanges beforeSave(BeforeSaveParameters parameters) throws EppException {
return parameters.entityChanges();
}
/** A class to encapsulate parameters for a call to {@link #afterValidation}. */
@ -59,6 +59,7 @@ public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
public abstract static class AfterValidationParameters extends ImmutableObject {
public abstract InternetDomainName domainName();
public abstract int years();
public static Builder newBuilder() {
@ -68,8 +69,11 @@ public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
/** Builder for {@link AfterValidationParameters}. */
@AutoValue.Builder
public abstract static class Builder {
public abstract Builder setDomainName(InternetDomainName domainName);
public abstract Builder setYears(int years);
public abstract AfterValidationParameters build();
}
}
@ -79,7 +83,11 @@ public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
public abstract static class BeforeSaveParameters extends ImmutableObject {
public abstract DomainResource newDomain();
public abstract HistoryEntry historyEntry();
public abstract EntityChanges entityChanges();
public abstract int years();
public static Builder newBuilder() {
@ -89,9 +97,15 @@ public class DomainCreateFlowCustomLogic extends BaseFlowCustomLogic {
/** Builder for {@link BeforeSaveParameters}. */
@AutoValue.Builder
public abstract static class Builder {
public abstract Builder setNewDomain(DomainResource newDomain);
public abstract Builder setHistoryEntry(HistoryEntry historyEntry);
public abstract Builder setEntityChanges(EntityChanges entityChanges);
public abstract Builder setYears(int years);
public abstract BeforeSaveParameters build();
}
}