zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix another instance of generic abuse

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=125064618
This commit is contained in:
cgoldfeder 2016-06-16 08:49:25 -07:00 • committed by Ben McIlwain
parent 3be61a13b5
commit a277e7c040
1 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

24
java/google/registry/flows/SessionMetadata.java
View file

@ -74,15 +74,21 @@ public abstract class SessionMetadata {
/** Subclasses can override this to verify that this is a valid session. */ /** Subclasses can override this to verify that this is a valid session. */
protected void checkValid() {} protected void checkValid() {}
protected void setPropertyChecked(String key, Object value) { /** Check that the session is valid and set a property. */
private void setPropertyChecked(String key, Object value) {
checkValid(); checkValid();
setProperty(key, value); setProperty(key, value);
} }
@SuppressWarnings("unchecked") /**
protected <T> T getPropertyChecked(String key) { * Check that the session is valid and get a property as a given type.
*
* @param clazz type to return, specified as a param to enforce typesafe generics
* @see "http://errorprone.info/bugpattern/TypeParameterUnusedInFormals"
*/
private <T> T getProperty(Class<T> clazz, String key) {
checkValid(); checkValid();
return (T) getProperty(key); return clazz.cast(getProperty(key));
} }
public TransportCredentials getTransportCredentials() { public TransportCredentials getTransportCredentials() {
@ -96,15 +102,16 @@ public abstract class SessionMetadata {
} }
public String getClientId() { public String getClientId() {
return getPropertyChecked(CLIENT_ID_KEY); return getProperty(String.class, CLIENT_ID_KEY);
} }
public boolean isSuperuser() { public boolean isSuperuser() {
return Boolean.TRUE.equals(getPropertyChecked(SUPERUSER_KEY)); return Boolean.TRUE.equals(getProperty(Boolean.class, SUPERUSER_KEY));
} }
@SuppressWarnings("unchecked")
public Set<String> getServiceExtensionUris() { public Set<String> getServiceExtensionUris() {
return getPropertyChecked(SERVICE_EXTENSIONS_KEY); return getProperty(Set.class, SERVICE_EXTENSIONS_KEY);
} }
public abstract SessionSource getSessionSource(); public abstract SessionSource getSessionSource();
@ -130,7 +137,8 @@ public abstract class SessionMetadata {
} }
public int getFailedLoginAttempts() { public int getFailedLoginAttempts() {
return ((Integer) Optional.fromNullable(getPropertyChecked(FAILED_LOGIN_ATTEMPTS_KEY)).or(0)); return Optional.fromNullable(getProperty(Integer.class, FAILED_LOGIN_ATTEMPTS_KEY))
.or(0);
} }
public void incrementFailedLoginAttempts() { public void incrementFailedLoginAttempts() {