zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove stale TODO on setting GoogleCredential data

Browse source 
We simply don't need to do this.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136058076
This commit is contained in:
mcilwain 2016-10-13 10:42:44 -07:00 • committed by Ben McIlwain
parent 77e826997d
commit a13f6aded8
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
java/google/registry/request/Modules.java
View file

@ -229,8 +229,6 @@ public final class Modules {
.setJsonFactory(googleCredential.getJsonFactory()) .setJsonFactory(googleCredential.getJsonFactory())
.setServiceAccountId(googleCredential.getServiceAccountId()) .setServiceAccountId(googleCredential.getServiceAccountId())
.setServiceAccountPrivateKey(googleCredential.getServiceAccountPrivateKey()) .setServiceAccountPrivateKey(googleCredential.getServiceAccountPrivateKey())
// TODO(b/31317128): Also set serviceAccountProjectId from value off googleCredential when
// that functionality is publicly released.
// Set the scopes to empty because the default value is null, which throws an NPE in the // Set the scopes to empty because the default value is null, which throws an NPE in the
// GoogleCredential constructor. We don't yet know the actual scopes to use here, and it // GoogleCredential constructor. We don't yet know the actual scopes to use here, and it
// is thus the responsibility of every user of a delegated admin credential to call // is thus the responsibility of every user of a delegated admin credential to call