zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-25 03:58:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Decentralize how registry phase checks are done in flows

Browse source 
Very few flows actually check the phase. Push the checks down to the leaf
flows so that we can remove the inherited code from ResourceFlow and replace
it with utility methods. In the process, document and test two places that
throw the exception but did not previously test it.

This introduces a temporary hack in BaseDomainCreateFlow that does something
specific for DomainApplicationCreateFlow. It will go away literally tomorrow
when I flatten that flow.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135480538
This commit is contained in:
cgoldfeder 2016-10-07 08:52:46 -07:00 • committed by Ben McIlwain
parent aaa84d6ec6
commit a09d48a4a5
18 changed files with 166 additions and 129 deletions
Download patch file Download diff file Expand all files Collapse all files

9
docs/flows.md
View file

@ -534,6 +534,8 @@ An EPP flow that deletes a domain.
### Errors
* 2002
* Command is not allowed in the current registry phase.
* 2201
* The specified resource belongs to another client.
* Only a tool can pass a metadata extension.
@ -555,7 +557,6 @@ An EPP flow that creates a new domain resource.
* 2002
* Service extension(s) must be declared at login.
* Command is not allowed in the current registry phase.
* Signed marks are not accepted in the current registry phase.
* The current registry phase does not allow for general registrations.
* 2003
@ -625,6 +626,8 @@ This flow also supports the EPP fee extension and can return pricing information
### Errors
* 2002
* Command is not allowed in the current registry phase.
* 2004
* Domain label is not allowed by IDN table.
* Domain name is under tld which doesn't exist.
@ -743,9 +746,9 @@ An EPP flow that creates a new application for a domain resource.
### Errors
* 2002
* Command is not allowed in the current registry phase.
* A notice cannot be specified when using a signed mark.
* Sunrise applications are disallowed during landrush.
* Command is not allowed in the current registry phase.
* 2003
* Landrush applications are disallowed during sunrise.
* Fees must be explicitly acknowledged when performing any operations on a premium name.
@ -843,6 +846,8 @@ An EPP flow that checks whether strings are trademarked.
* 2002
* Command is not allowed in the current registry phase.
* Claims checks are not allowed during sunrise.
* The claims period has ended.
* 2004
* Domain name is under tld which doesn't exist.
* 2201