zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-12 05:58:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Resolve TODOs under Shicong's name (#930)

Browse source
This commit is contained in:
Shicong Huang 2021-01-15 14:22:31 -05:00 • committed by GitHub
parent 9e6f99face
commit 9b5805f145
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 14 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

3
core/src/test/java/google/registry/model/history/DomainHistoryTest.java
View file

@ -221,8 +221,7 @@ public class DomainHistoryTest extends EntityTestCase {
.setGracePeriods(
ImmutableSet.of(
GracePeriod.create(
GracePeriodStatus.ADD, "domainRepoId", END_OF_TIME, "clientId", null)
.cloneWithPrepopulatedId()))
GracePeriodStatus.ADD, "domainRepoId", END_OF_TIME, "clientId", null)))
.build();
}

4
core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerImplTest.java
View file

@ -48,8 +48,8 @@ import org.junit.jupiter.api.extension.RegisterExtension;
* Unit tests for SQL only APIs defined in {@link JpaTransactionManagerImpl}. Note that the tests
* for common APIs in {@link TransactionManager} are added in {@link TransactionManagerTest}.
*
* <p>TODO(shicong): Remove duplicate tests that covered by TransactionManagerTest by refactoring
* the test schema.
* <p>TODO(b/177587763): Remove duplicate tests that covered by TransactionManagerTest by
* refactoring the test schema.
*/
class JpaTransactionManagerImplTest {