zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 16:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove "@ForOverride" from .toString and .equals

Browse source 
Inheriting classes reimplementing these methods might want to call the super.
version of them in some cases (only change the default behavior for some
methods).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=149772767
This commit is contained in:
Ben McIlwain 2017-03-10 10:38:45 -08:00
parent 9174855a47
commit 9a11f125ff
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
java/google/registry/util/ComparingInvocationHandler.java
View file

@ -15,7 +15,6 @@
package google.registry.util; package google.registry.util;
import com.google.common.reflect.Reflection; import com.google.common.reflect.Reflection;
import com.google.errorprone.annotations.ForOverride;
import java.lang.reflect.InvocationHandler; import java.lang.reflect.InvocationHandler;
import java.lang.reflect.InvocationTargetException; import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method; import java.lang.reflect.Method;
@ -72,7 +71,6 @@ public abstract class ComparingInvocationHandler<T> implements InvocationHandler
* @param method the method where the difference was found * @param method the method where the difference was found
* @param message human readable description of the difference found * @param message human readable description of the difference found
*/ */
@ForOverride
protected abstract void log(Method method, String message); protected abstract void log(Method method, String message);
/** /**
@ -85,7 +83,6 @@ public abstract class ComparingInvocationHandler<T> implements InvocationHandler
* @param method the method whose return value is given * @param method the method whose return value is given
* @param object the object returned by a call to method * @param object the object returned by a call to method
*/ */
@ForOverride
protected String toString( protected String toString(
@SuppressWarnings("unused") Method method, @SuppressWarnings("unused") Method method,
@Nullable Object object) { @Nullable Object object) {
@ -103,7 +100,6 @@ public abstract class ComparingInvocationHandler<T> implements InvocationHandler
* @param actual the object returned by a call to method for the "actual" implementation * @param actual the object returned by a call to method for the "actual" implementation
* @param second the object returned by a call to method for the "second" implementation * @param second the object returned by a call to method for the "second" implementation
*/ */
@ForOverride
protected boolean equals( protected boolean equals(
@SuppressWarnings("unused") Method method, @SuppressWarnings("unused") Method method,
@Nullable Object actual, @Nullable Object actual,
@ -121,7 +117,6 @@ public abstract class ComparingInvocationHandler<T> implements InvocationHandler
* @param actual the exception thrown by a call to method for the "actual" implementation * @param actual the exception thrown by a call to method for the "actual" implementation
* @param second the exception thrown by a call to method for the "second" implementation * @param second the exception thrown by a call to method for the "second" implementation
*/ */
@ForOverride
protected boolean exceptionEquals( protected boolean exceptionEquals(
@SuppressWarnings("unused") Method method, @SuppressWarnings("unused") Method method,
Throwable actual, Throwable actual,
@ -138,7 +133,6 @@ public abstract class ComparingInvocationHandler<T> implements InvocationHandler
* @param method the method whose return value is given * @param method the method whose return value is given
* @param exception the exception thrown by a call to method * @param exception the exception thrown by a call to method
*/ */
@ForOverride
protected String exceptionToString( protected String exceptionToString(
@SuppressWarnings("unused") Method method, @SuppressWarnings("unused") Method method,
Throwable exception) { Throwable exception) {