zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-22 04:09:46 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add logging on input failure for registrar-settings

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=191369657
This commit is contained in:
guyben 2018-04-02 16:54:21 -07:00 • committed by Ben McIlwain
parent 87a58dbcae
commit 951ba78cef
1 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

20
java/google/registry/ui/server/registrar/RegistrarSettingsAction.java
View file

@ -44,6 +44,7 @@ import google.registry.ui.forms.FormFieldException;
import google.registry.ui.server.RegistrarFormFields; import google.registry.ui.server.RegistrarFormFields;
import google.registry.util.CollectionUtils; import google.registry.util.CollectionUtils;
import google.registry.util.DiffUtils; import google.registry.util.DiffUtils;
import google.registry.util.FormattingLogger;
import java.util.HashSet; import java.util.HashSet;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.List; import java.util.List;
@ -67,6 +68,8 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
public static final String PATH = "/registrar-settings"; public static final String PATH = "/registrar-settings";
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
static final String OP_PARAM = "op"; static final String OP_PARAM = "op";
static final String ARGS_PARAM = "args"; static final String ARGS_PARAM = "args";
@ -100,6 +103,11 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
Map<String, ?> args = (Map<String, Object>) Map<String, ?> args = (Map<String, Object>)
Optional.<Object>ofNullable(input.get(ARGS_PARAM)).orElse(ImmutableMap.of()); Optional.<Object>ofNullable(input.get(ARGS_PARAM)).orElse(ImmutableMap.of());
logger.infofmt(
"Received request '%s' on registrar '%s' with args %s",
op,
initialRegistrar.getClientId(),
args);
try { try {
switch (op) { switch (op) {
case "update": case "update":
@ -110,8 +118,20 @@ public class RegistrarSettingsAction implements Runnable, JsonActionRunner.JsonA
return JsonResponseHelper.create(ERROR, "Unknown or unsupported operation: " + op); return JsonResponseHelper.create(ERROR, "Unknown or unsupported operation: " + op);
} }
} catch (FormFieldException e) { } catch (FormFieldException e) {
logger.warningfmt(
e,
"Failed to perform operation '%s' on registrar '%s' for args %s",
op,
initialRegistrar.getClientId(),
args);
return JsonResponseHelper.createFormFieldError(e.getMessage(), e.getFieldName()); return JsonResponseHelper.createFormFieldError(e.getMessage(), e.getFieldName());
} catch (FormException ee) { } catch (FormException ee) {
logger.warningfmt(
ee,
"Failed to perform operation '%s' on registrar '%s' for args %s",
op,
initialRegistrar.getClientId(),
args);
return JsonResponseHelper.create(ERROR, ee.getMessage()); return JsonResponseHelper.create(ERROR, ee.getMessage());
} }