zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-25 20:18:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove slash from console contacts endpoint (#2045)

Browse source 
Endpoints shouldn't themselves end in slashes
This commit is contained in:
gbrodman 2023-06-02 15:32:18 -04:00 • committed by GitHub
parent db1b92638f
commit 931a350f3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/google/registry/ui/server/console/settings/ContactAction.java
View file

@ -48,7 +48,7 @@ import javax.servlet.http.HttpServletRequest;
method = {GET, POST}, method = {GET, POST},
auth = Auth.AUTH_PUBLIC_LOGGED_IN) auth = Auth.AUTH_PUBLIC_LOGGED_IN)
public class ContactAction implements JsonGetAction { public class ContactAction implements JsonGetAction {
static final String PATH = "/console-api/settings/contacts/"; static final String PATH = "/console-api/settings/contacts";
private static final FluentLogger logger = FluentLogger.forEnclosingClass(); private static final FluentLogger logger = FluentLogger.forEnclosingClass();
private final HttpServletRequest req; private final HttpServletRequest req;
private final AuthResult authResult; private final AuthResult authResult;

1
core/src/test/java/google/registry/server/RegistryTestServer.java
View file

@ -50,6 +50,7 @@ public final class RegistryTestServer {
route("/whois/*", FrontendServlet.class), route("/whois/*", FrontendServlet.class),
route("/rdap/*", FrontendServlet.class), route("/rdap/*", FrontendServlet.class),
route("/check", FrontendServlet.class), route("/check", FrontendServlet.class),
route("/console-api/*", FrontendServlet.class),
// Proxy Services // Proxy Services
route("/_dr/epp", FrontendServlet.class), route("/_dr/epp", FrontendServlet.class),

24
core/src/test/resources/google/registry/module/frontend/frontend_routing.txt
View file

@ -1,12 +1,12 @@
PATH CLASS METHODS OK AUTH_METHODS MIN USER_POLICY PATH CLASS METHODS OK AUTH_METHODS MIN USER_POLICY
/_dr/epp EppTlsAction POST n INTERNAL,API APP PUBLIC /_dr/epp EppTlsAction POST n INTERNAL,API APP PUBLIC
/console-api/domain ConsoleDomainGetAction GET n API,LEGACY USER PUBLIC /console-api/domain ConsoleDomainGetAction GET n API,LEGACY USER PUBLIC
/console-api/settings/contacts/ ContactAction GET,POST n API,LEGACY USER PUBLIC /console-api/settings/contacts ContactAction GET,POST n API,LEGACY USER PUBLIC
/registrar ConsoleUiAction GET n INTERNAL,API,LEGACY NONE PUBLIC /registrar ConsoleUiAction GET n INTERNAL,API,LEGACY NONE PUBLIC
/registrar-create ConsoleRegistrarCreatorAction POST,GET n INTERNAL,API,LEGACY NONE PUBLIC /registrar-create ConsoleRegistrarCreatorAction POST,GET n INTERNAL,API,LEGACY NONE PUBLIC
/registrar-ote-setup ConsoleOteSetupAction POST,GET n INTERNAL,API,LEGACY NONE PUBLIC /registrar-ote-setup ConsoleOteSetupAction POST,GET n INTERNAL,API,LEGACY NONE PUBLIC
/registrar-ote-status OteStatusAction POST n API,LEGACY USER PUBLIC /registrar-ote-status OteStatusAction POST n API,LEGACY USER PUBLIC
/registrar-settings RegistrarSettingsAction POST n API,LEGACY USER PUBLIC /registrar-settings RegistrarSettingsAction POST n API,LEGACY USER PUBLIC
/registry-lock-get RegistryLockGetAction GET n API,LEGACY USER PUBLIC /registry-lock-get RegistryLockGetAction GET n API,LEGACY USER PUBLIC
/registry-lock-post RegistryLockPostAction POST n API,LEGACY USER PUBLIC /registry-lock-post RegistryLockPostAction POST n API,LEGACY USER PUBLIC
/registry-lock-verify RegistryLockVerifyAction GET n API,LEGACY USER PUBLIC /registry-lock-verify RegistryLockVerifyAction GET n API,LEGACY USER PUBLIC