zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-22 18:55:58 +02:00
Code Issues Projects Releases Packages Wiki Activity

Detach entities loaded by loadSingleton() (#1184)

Browse source 
* Detach entities loaded by loadSingleton()

* Reformatted
This commit is contained in:
Michael Muller 2021-06-01 14:22:57 -04:00 • committed by GitHub
parent 810adf0158
commit 92f5f8989b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java
View file

@ -504,7 +504,7 @@ public class JpaTransactionManagerImpl implements JpaTransactionManager {
elements.size() <= 1,
"Expected at most one entity of type %s, found at least two",
clazz.getSimpleName());
return elements.stream().findFirst();
return elements.stream().findFirst().map(this::detach);
}
private int internalDelete(VKey<?> key) {

13
core/src/test/java/google/registry/persistence/transaction/JpaTransactionManagerImplTest.java
View file

@ -508,6 +508,19 @@ class JpaTransactionManagerImplTest {
assertThat(persisted).containsExactlyElementsIn(moreEntities);
}
@Test
void loadSingleton_detaches() {
jpaTm().transact(() -> jpaTm().insert(theEntity));
jpaTm()
.transact(
() ->
assertThat(
jpaTm()
.getEntityManager()
.contains(jpaTm().loadSingleton(TestEntity.class).get())))
.isFalse();
}
@Test
void delete_succeeds() {
jpaTm().transact(() -> jpaTm().insert(theEntity));