zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-04 17:01:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Always validate domain name on allocation token (#498)

Browse source 
* Always validate domain name on allocation token

This is in response to a client-reported error, where they accidentally sent the
wrong domain name on a domain create that included an allocation token. What
should have happened (and that now happens as of this commit) is an error being
thrown that the allocation token does not match the domain name being created.
What happened instead was that, since the incorrectly submitted domain name was
not reserved, the create succeeded (as it would for all creates of unreserved
domains in GA) and the allocation token was redeemed, which is not what you'd
expect.

* Fix tests to reflect changed check behavior
This commit is contained in:
Ben McIlwain 2020-02-27 16:48:37 -05:00 • committed by GitHub
parent 429bc8e6d2
commit 9283cd263f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 105 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/flows.md
View file

@ -357,6 +357,7 @@ An EPP flow that creates a new domain resource.
* Registrant is not whitelisted for this TLD.
* Requested domain does not require a claims notice.
* 2305
* The allocation token is not valid for this domain.
* The allocation token is not valid for this registrar.
* The allocation token is not valid for this TLD.
* The allocation token was already redeemed.