zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-21 10:16:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

Delete screenshots folder in fragile test first (#735)

Browse source 
It is not clear to me why this folder is deleted in standardTest first,
presumably this is done when the webdriver tests were part of
standardTest?

Also not clear to me is why screenshots are only deleted in presubmits
but not locally. At least on my workstation standardTest runs after
fragileTest, just like in kokoro, so it should have deleted the
screenshots
folder, but it didn't.

Regardless, the correct thing to do is to delete this folder first in
fragileTest so that it doesn't interfere with the results.
This commit is contained in:
Lai Jiang 2020-08-03 11:46:34 -04:00 • committed by GitHub
parent e95ce30fa6
commit 90d080d42f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
core/build.gradle
View file

@ -705,6 +705,10 @@ task fragileTest(type: FilteringTest) {
// Run every test class in a freshly started process. // Run every test class in a freshly started process.
forkEvery 1 forkEvery 1
doFirst {
new File(screenshotsDir).deleteDir()
}
} }
task outcastTest(type: FilteringTest) { task outcastTest(type: FilteringTest) {
@ -897,10 +901,6 @@ task standardTest(type: FilteringTest) {
systemProperty 'test.projectRoot', rootProject.projectRootDir systemProperty 'test.projectRoot', rootProject.projectRootDir
systemProperty 'test.resourcesDir', resourcesDir systemProperty 'test.resourcesDir', resourcesDir
doFirst {
new File(screenshotsDir).deleteDir()
}
} }
test { test {