zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-29 08:50:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

Switch Random to SecureRandom

Browse source 
Someone may @Inject a Random at some point in the future where security matters,
so always provide a secure one.

Also, this shouldn't be in ConfigModule (it's not configuration) -- but that can
be changed separately. We might want a larger refactor that has a utils module
or similar to provide extremely generic things like random number generators.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=217602486
This commit is contained in:
mcilwain 2018-10-17 15:43:22 -07:00 • committed by jianglai
parent 82252dfcd6
commit 8e67cc7cbb
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
java/google/registry/config/RegistryConfig.java
View file

@ -33,6 +33,7 @@ import java.lang.annotation.Documented;
import java.lang.annotation.Retention; import java.lang.annotation.Retention;
import java.net.URI; import java.net.URI;
import java.net.URL; import java.net.URL;
import java.security.SecureRandom;
import java.util.Optional; import java.util.Optional;
import java.util.Random; import java.util.Random;
import java.util.stream.Collectors; import java.util.stream.Collectors;
@ -1267,7 +1268,7 @@ public final class RegistryConfig {
@Singleton @Singleton
@Provides @Provides
public static Random provideRandom() { public static Random provideRandom() {
return new Random(); return new SecureRandom();
} }
} }