mirror of
https://github.com/google/nomulus.git
synced 2025-07-05 18:53:34 +02:00
Require explict tag when starting psql docker (#368)
* Require explict tag when starting psql docker Defined a util class to return docker tag of desired PSQL version. Class is defined in ':db' and shared by ':db' and ':core'. Used an artifact declaration to exclude unnecesary compile dependencies. Added a presubmit check for instantiations without explicit tag.
This commit is contained in:
parent
bd27840068
commit
8e3b7b4efb
10 changed files with 69 additions and 7 deletions
|
@ -99,6 +99,12 @@ PRESUBMITS = {
|
|||
"System.(out|err).println is only allowed in tools/ packages. Please "
|
||||
"use a logger instead.",
|
||||
|
||||
# PostgreSQLContainer instantiation must specify docker tag
|
||||
PresubmitCheck(
|
||||
r"[\s\S]*new\s+PostgreSQLContainer(<[\s\S]*>)?\(\s*\)[\s\S]*",
|
||||
"java", {}):
|
||||
"PostgreSQLContainer instantiation must specify docker tag.",
|
||||
|
||||
# Various Soy linting checks
|
||||
PresubmitCheck(
|
||||
r".* (/\*)?\* {?@param ",
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue