From 8d97fa58580aa03f7531c0ce5595a5a9a18c1a35 Mon Sep 17 00:00:00 2001 From: mountford Date: Thu, 10 Nov 2016 09:28:22 -0800 Subject: [PATCH] Add TLD-specific logic for application creates This CL applies the status flag logic, but doesn't yet do any name checking ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=138769004 --- .../domain/DomainApplicationCreateFlow.java | 1 - .../flows/domain/RegistryExtraFlowLogic.java | 1 - .../testdata/application_create_no_flags.xml | 27 ++++++++++++++++ .../testdata/application_create_one_flag.xml | 30 ++++++++++++++++++ .../testdata/application_create_two_flags.xml | 31 +++++++++++++++++++ .../model/domain/TestExtraLogicManager.java | 1 - 6 files changed, 88 insertions(+), 3 deletions(-) create mode 100644 javatests/google/registry/flows/dotapp/testdata/application_create_no_flags.xml create mode 100644 javatests/google/registry/flows/dotapp/testdata/application_create_one_flag.xml create mode 100644 javatests/google/registry/flows/dotapp/testdata/application_create_two_flags.xml diff --git a/java/google/registry/flows/domain/DomainApplicationCreateFlow.java b/java/google/registry/flows/domain/DomainApplicationCreateFlow.java index c45eaf386..6977c10b0 100644 --- a/java/google/registry/flows/domain/DomainApplicationCreateFlow.java +++ b/java/google/registry/flows/domain/DomainApplicationCreateFlow.java @@ -358,7 +358,6 @@ public final class DomainApplicationCreateFlow implements TransactionalFlow { extraFlowLogic.get().performAdditionalApplicationCreateLogic( newApplication, clientId, - newApplication.getCreationTime(), years, eppInput, historyEntry); diff --git a/java/google/registry/flows/domain/RegistryExtraFlowLogic.java b/java/google/registry/flows/domain/RegistryExtraFlowLogic.java index 5a63ea072..632d55da6 100644 --- a/java/google/registry/flows/domain/RegistryExtraFlowLogic.java +++ b/java/google/registry/flows/domain/RegistryExtraFlowLogic.java @@ -41,7 +41,6 @@ public interface RegistryExtraFlowLogic { public void performAdditionalApplicationCreateLogic( DomainApplication application, String clientId, - DateTime asOfDate, int years, EppInput eppInput, HistoryEntry historyEntry) throws EppException; diff --git a/javatests/google/registry/flows/dotapp/testdata/application_create_no_flags.xml b/javatests/google/registry/flows/dotapp/testdata/application_create_no_flags.xml new file mode 100644 index 000000000..6e444dcb5 --- /dev/null +++ b/javatests/google/registry/flows/dotapp/testdata/application_create_no_flags.xml @@ -0,0 +1,27 @@ + + + + + example.tld + 1 + + ns1.example.net + ns2.example.net + + jd1234 + sh8013 + sh8013 + + 2fooBAR + + + + + + sunrise + + + ABC-12345 + + diff --git a/javatests/google/registry/flows/dotapp/testdata/application_create_one_flag.xml b/javatests/google/registry/flows/dotapp/testdata/application_create_one_flag.xml new file mode 100644 index 000000000..721e5cfe6 --- /dev/null +++ b/javatests/google/registry/flows/dotapp/testdata/application_create_one_flag.xml @@ -0,0 +1,30 @@ + + + + + example.tld + 1 + + ns1.example.net + ns2.example.net + + jd1234 + sh8013 + sh8013 + + 2fooBAR + + + + + + %FLAG% + + + sunrise + + + ABC-12345 + + diff --git a/javatests/google/registry/flows/dotapp/testdata/application_create_two_flags.xml b/javatests/google/registry/flows/dotapp/testdata/application_create_two_flags.xml new file mode 100644 index 000000000..15f36388e --- /dev/null +++ b/javatests/google/registry/flows/dotapp/testdata/application_create_two_flags.xml @@ -0,0 +1,31 @@ + + + + + example.tld + 1 + + ns1.example.net + ns2.example.net + + jd1234 + sh8013 + sh8013 + + 2fooBAR + + + + + + %FLAG1% + %FLAG2% + + + sunrise + + + ABC-12345 + + diff --git a/javatests/google/registry/model/domain/TestExtraLogicManager.java b/javatests/google/registry/model/domain/TestExtraLogicManager.java index 73573aa5b..6adab8e2d 100644 --- a/javatests/google/registry/model/domain/TestExtraLogicManager.java +++ b/javatests/google/registry/model/domain/TestExtraLogicManager.java @@ -118,7 +118,6 @@ public class TestExtraLogicManager implements RegistryExtraFlowLogic { public void performAdditionalApplicationCreateLogic( DomainApplication application, String clientId, - DateTime asOfDate, int years, EppInput eppInput, HistoryEntry historyEntry) throws EppException {