zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-23 19:20:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove unnecessary if statements in CloudDnsWriter (#2071)

Browse source 
The condition they are guarding against cannot possibly occur.
This commit is contained in:
Ben McIlwain 2023-07-07 13:15:02 -04:00 • committed by GitHub
parent fe19f0fe78
commit 8d22c2a8d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/google/registry/dns/writer/clouddns/CloudDnsWriter.java
View file

@ -144,7 +144,6 @@ public class CloudDnsWriter extends BaseDnsWriter {
dsRrData.add(ds.toRrData());
}
if (!dsRrData.isEmpty()) {
domainRecords.add(
new ResourceRecordSet()
.setName(absoluteDomainName)
@ -153,7 +152,6 @@ public class CloudDnsWriter extends BaseDnsWriter {
.setKind("dns#resourceRecordSet")
.setRrdatas(ImmutableList.copyOf(dsRrData)));
}
}
// Construct NS records (if any).
Set<String> nameserverData = domain.get().loadNameserverHostNames();
@ -169,7 +167,6 @@ public class CloudDnsWriter extends BaseDnsWriter {
}
}
if (!nsRrData.isEmpty()) {
domainRecords.add(
new ResourceRecordSet()
.setName(absoluteDomainName)
@ -178,7 +175,6 @@ public class CloudDnsWriter extends BaseDnsWriter {
.setKind("dns#resourceRecordSet")
.setRrdatas(ImmutableList.copyOf(nsRrData)));
}
}
desiredRecords.put(absoluteDomainName, domainRecords.build());
logger.atFine().log(