From 8a8276e838d474c632246e78634a44cc475d19d3 Mon Sep 17 00:00:00 2001 From: lukes Date: Tue, 29 Nov 2016 07:13:27 -0800 Subject: [PATCH] =?UTF-8?q?=E2=80=8B=E2=80=8B=E2=80=8BRemove=20html=20ambi?= =?UTF-8?q?guity=20from=20soy=20templates.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Soy is gaining support for parsing/validating html structure and as such a number of patterns will start getting rejected by the parser. This change fixes newly errant soy templates by: * transforming '<' characters that are not part of html tags to '<' * inserting whitespace following tag names so that they are unambiguous * changing templates not rendering html to kind="text" so html rules don't apply * fixing control flow such that all tags (and quoted attribute values) are completely defined within a single control flow block. In some cases this required extracting {let..} vars or whole templates and in others it required duplicating conditions. * removing stray unmatched quote characters in html tags. * fixing incorrectly written html comments LSC: https://docs.google.com/document/d/18MLrX8kUVzYGe1dBaSfh1kcQ_1UB02QHOk4KZtvHkIc/edit# Tested: $ blaze test //third_party/java_src/gtld/java/google/registry/flows:all //third_party/java_src/gtld/java/google/registry/tools/soy:all ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=140475284 --- java/google/registry/tools/soy/DomainApplicationInfo.soy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/google/registry/tools/soy/DomainApplicationInfo.soy b/java/google/registry/tools/soy/DomainApplicationInfo.soy index 56b8aaf95..e5f375c0e 100644 --- a/java/google/registry/tools/soy/DomainApplicationInfo.soy +++ b/java/google/registry/tools/soy/DomainApplicationInfo.soy @@ -33,7 +33,7 @@ - {$phase} + {$phase} {$id}