Rename process_time column in DnsRefreshRequest (#1962)

Make it explicit that this is the last process time, not a scheduled
future process time.
This commit is contained in:
Lai Jiang 2023-03-14 14:03:12 -04:00 committed by GitHub
parent 59f457b2d7
commit 8a4252186a
5 changed files with 52 additions and 31 deletions

View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2023-03-09 22:05:25.449957</td>
<td class="property_value">2023-03-14 17:02:14.207181</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V139__add_allowed_epp_actions_column.sql</td>
<td id="lastFlywayFile" class="property_value">V140__rename_process_time_column_in_dns_refresh_request_table.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="3835.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2023-03-09 22:05:25.449957
2023-03-14 17:02:14.207181
</text>
<polygon fill="none" stroke="#888888" points="3748,-4 3748,-44 4013,-44 4013,-4 3748,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
@ -2255,12 +2255,12 @@ td.section {
<text text-anchor="start" x="3676.5" y="-2039.8" font-family="Helvetica,sans-Serif" font-weight="bold" font-style="italic" font-size="14.00">
id
</text>
<text text-anchor="start" x="3803.5" y="-2038.8" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="3817.5" y="-2038.8" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="3853.5" y="-2038.8" font-family="Helvetica,sans-Serif" font-size="14.00">
bigserial not null
</text>
<text text-anchor="start" x="3803.5" y="-2019.8" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="3817.5" y="-2019.8" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="3853.5" y="-2019.8" font-family="Helvetica,sans-Serif" font-size="14.00">
auto-incremented
@ -2268,15 +2268,15 @@ td.section {
<text text-anchor="start" x="3676.5" y="-2000.8" font-family="Helvetica,sans-Serif" font-size="14.00">
request_time
</text>
<text text-anchor="start" x="3803.5" y="-2000.8" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="3817.5" y="-2000.8" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="3853.5" y="-2000.8" font-family="Helvetica,sans-Serif" font-size="14.00">
timestamptz not null
</text>
<text text-anchor="start" x="3676.5" y="-1981.8" font-family="Helvetica,sans-Serif" font-size="14.00">
process_time
last_process_time
</text>
<text text-anchor="start" x="3803.5" y="-1981.8" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="3817.5" y="-1981.8" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="3853.5" y="-1981.8" font-family="Helvetica,sans-Serif" font-size="14.00">
timestamptz not null
@ -4432,7 +4432,7 @@ td.section {
</tr>
<tr>
<td class="spacer"></td>
<td class="minwidth">process_time</td>
<td class="minwidth">last_process_time</td>
<td class="minwidth">timestamptz not null</td>
</tr>
<tr>

View file

@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2023-03-09 22:05:23.270136</td>
<td class="property_value">2023-03-14 17:02:11.913219</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V139__add_allowed_epp_actions_column.sql</td>
<td id="lastFlywayFile" class="property_value">V140__rename_process_time_column_in_dns_refresh_request_table.sql</td>
</tr>
</tbody>
</table>
@ -284,7 +284,7 @@ td.section {
generated on
</text>
<text text-anchor="start" x="4519.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
2023-03-09 22:05:23.270136
2023-03-14 17:02:11.913219
</text>
<polygon fill="none" stroke="#888888" points="4432,-4 4432,-44 4697,-44 4697,-4 4432,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
@ -5103,12 +5103,12 @@ td.section {
<text text-anchor="start" x="4319" y="-5486.3" font-family="Helvetica,sans-Serif" font-weight="bold" font-style="italic" font-size="14.00">
id
</text>
<text text-anchor="start" x="4446" y="-5485.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5485.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5485.3" font-family="Helvetica,sans-Serif" font-size="14.00">
bigserial not null
</text>
<text text-anchor="start" x="4446" y="-5466.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5466.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5466.3" font-family="Helvetica,sans-Serif" font-size="14.00">
auto-incremented
@ -5116,7 +5116,7 @@ td.section {
<text text-anchor="start" x="4319" y="-5447.3" font-family="Helvetica,sans-Serif" font-size="14.00">
name
</text>
<text text-anchor="start" x="4446" y="-5447.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5447.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5447.3" font-family="Helvetica,sans-Serif" font-size="14.00">
text not null
@ -5124,7 +5124,7 @@ td.section {
<text text-anchor="start" x="4319" y="-5428.3" font-family="Helvetica,sans-Serif" font-size="14.00">
request_time
</text>
<text text-anchor="start" x="4446" y="-5428.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5428.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5428.3" font-family="Helvetica,sans-Serif" font-size="14.00">
timestamptz not null
@ -5132,7 +5132,7 @@ td.section {
<text text-anchor="start" x="4319" y="-5409.3" font-family="Helvetica,sans-Serif" font-size="14.00">
tld
</text>
<text text-anchor="start" x="4446" y="-5409.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5409.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5409.3" font-family="Helvetica,sans-Serif" font-size="14.00">
text not null
@ -5140,15 +5140,15 @@ td.section {
<text text-anchor="start" x="4319" y="-5390.3" font-family="Helvetica,sans-Serif" font-size="14.00">
type
</text>
<text text-anchor="start" x="4446" y="-5390.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5390.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5390.3" font-family="Helvetica,sans-Serif" font-size="14.00">
text not null
</text>
<text text-anchor="start" x="4319" y="-5371.3" font-family="Helvetica,sans-Serif" font-size="14.00">
process_time
last_process_time
</text>
<text text-anchor="start" x="4446" y="-5371.3" font-family="Helvetica,sans-Serif" font-size="14.00">
<text text-anchor="start" x="4460" y="-5371.3" font-family="Helvetica,sans-Serif" font-size="14.00">
</text>
<text text-anchor="start" x="4496" y="-5371.3" font-family="Helvetica,sans-Serif" font-size="14.00">
timestamptz not null
@ -9199,7 +9199,7 @@ td.section {
</tr>
<tr>
<td class="spacer"></td>
<td class="minwidth">process_time</td>
<td class="minwidth">last_process_time</td>
<td class="minwidth">timestamptz not null</td>
</tr>
<tr>
@ -9242,12 +9242,12 @@ td.section {
<td colspan="3"></td>
</tr>
<tr>
<td colspan="2" class="name">idx3i7i2ktts9d7lcjbs34h0pvwo</td>
<td colspan="2" class="name">idxfdk2xpil2x1gh0omt84k2y3o1</td>
<td class="description right">[non-unique index]</td>
</tr>
<tr>
<td class="spacer"></td>
<td class="minwidth">process_time</td>
<td class="minwidth">last_process_time</td>
<td class="minwidth">ascending</td>
</tr>
<tr>

View file

@ -137,3 +137,4 @@ V136__add_dns_refresh_request_table.sql
V137__add_process_time_column.sql
V138__drop_dns_refresh_request_time_column.sql
V139__add_allowed_epp_actions_column.sql
V140__rename_process_time_column_in_dns_refresh_request_table.sql

View file

@ -0,0 +1,20 @@
-- Copyright 2023 The Nomulus Authors. All Rights Reserved.
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
ALTER TABLE "DnsRefreshRequest" RENAME COLUMN process_time TO last_process_time;
CREATE INDEX IDXfdk2xpil2x1gh0omt84k2y3o1 ON "DnsRefreshRequest" (last_process_time);
DROP INDEX IDX3i7i2ktts9d7lcjbs34h0pvwo;

View file

@ -351,7 +351,7 @@ CREATE TABLE public."DnsRefreshRequest" (
request_time timestamp with time zone NOT NULL,
tld text NOT NULL,
type text NOT NULL,
process_time timestamp with time zone NOT NULL
last_process_time timestamp with time zone NOT NULL
);
@ -1618,13 +1618,6 @@ CREATE INDEX idx1rcgkdd777bpvj0r94sltwd5y ON public."Domain" USING btree (domain
CREATE INDEX idx2exdfbx6oiiwnhr8j6gjpqt2j ON public."BillingCancellation" USING btree (event_time);
--
-- Name: idx3i7i2ktts9d7lcjbs34h0pvwo; Type: INDEX; Schema: public; Owner: -
--
CREATE INDEX idx3i7i2ktts9d7lcjbs34h0pvwo ON public."DnsRefreshRequest" USING btree (process_time);
--
-- Name: idx3y3k7m2bkgahm9sixiohgyrga; Type: INDEX; Schema: public; Owner: -
--
@ -1821,6 +1814,13 @@ CREATE INDEX idxe7wu46c7wpvfmfnj4565abibp ON public."PollMessage" USING btree (r
CREATE INDEX idxeokttmxtpq2hohcioe5t2242b ON public."BillingCancellation" USING btree (registrar_id);
--
-- Name: idxfdk2xpil2x1gh0omt84k2y3o1; Type: INDEX; Schema: public; Owner: -
--
CREATE INDEX idxfdk2xpil2x1gh0omt84k2y3o1 ON public."DnsRefreshRequest" USING btree (last_process_time);
--
-- Name: idxfg2nnjlujxo6cb9fha971bq2n; Type: INDEX; Schema: public; Owner: -
--