zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-12 04:29:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

Ignore read-only mode when running commit logs / backups (#1424)

Browse source 
We need to be able to continue running the backup and async replay code
while the database is in read-only mode
This commit is contained in:
gbrodman 2021-11-18 15:42:23 -05:00 • committed by GitHub
parent 1764ae0b3f
commit 8393c75929
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
core/src/main/java/google/registry/backup/BackupUtils.java
View file

@ -41,11 +41,12 @@ public class BackupUtils {
} }
/** /**
* Converts the given {@link ImmutableObject} to a raw Datastore entity and write it to an * Converts the given {@link ImmutableObject} to a raw Datastore entity and write it to an {@link
* {@link OutputStream} in delimited protocol buffer format. * OutputStream} in delimited protocol buffer format.
*/ */
static void serializeEntity(ImmutableObject entity, OutputStream stream) throws IOException { static void serializeEntity(ImmutableObject entity, OutputStream stream) throws IOException {
EntityTranslator.convertToPb(auditedOfy().save().toEntity(entity)).writeDelimitedTo(stream); EntityTranslator.convertToPb(auditedOfy().saveIgnoringReadOnly().toEntity(entity))
.writeDelimitedTo(stream);
} }
/** /**

2
core/src/main/java/google/registry/backup/CommitLogCheckpointAction.java
View file

@ -74,7 +74,7 @@ public final class CommitLogCheckpointAction implements Runnable {
return; return;
} }
auditedOfy() auditedOfy()
.saveWithoutBackup() .saveIgnoringReadOnly()
.entities( .entities(
checkpoint, CommitLogCheckpointRoot.create(checkpoint.getCheckpointTime())); checkpoint, CommitLogCheckpointRoot.create(checkpoint.getCheckpointTime()));
// Enqueue a diff task between previous and current checkpoints. // Enqueue a diff task between previous and current checkpoints.