Rename various fields and classes after migration (#1784)

Also fixed a bug introduced in #1785 where identity checked were performed instead of equality. This resulted in two sets containing the same elements not being regarded as equal and subsequent DNS updated being unnecessarily enqueued.
This commit is contained in:
Lai Jiang 2022-09-21 11:49:22 -04:00 committed by GitHub
parent 5bbad483e4
commit 82a3a49268
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
107 changed files with 528 additions and 573 deletions

View file

@ -61,14 +61,12 @@ public final class DomainNameUtils {
* google.registry.model.tld.Registries#findTldForName(InternetDomainName)
* Registries#findTldForName}, which will work on hostnames in addition to domains.
*
* @param fullyQualifiedDomainName must be a punycode SLD (not a host or unicode)
* @param domainName must be a punycode SLD (not a host or unicode)
* @throws IllegalArgumentException if there is no TLD
*/
public static String getTldFromDomainName(String fullyQualifiedDomainName) {
checkArgument(
!Strings.isNullOrEmpty(fullyQualifiedDomainName),
"fullyQualifiedDomainName cannot be null or empty");
return getTldFromDomainName(InternetDomainName.from(fullyQualifiedDomainName));
public static String getTldFromDomainName(String domainName) {
checkArgument(!Strings.isNullOrEmpty(domainName), "domainName cannot be null or empty");
return getTldFromDomainName(InternetDomainName.from(domainName));
}
/**