From 823bdc721fd2d5b6a93bb3bea343ba389fcd4845 Mon Sep 17 00:00:00 2001
From: mcilwain <mcilwain@google.com>
Date: Thu, 15 Sep 2016 15:43:45 -0700
Subject: [PATCH] Don't override toString() on enums

It is a bad idea to override toString() on enums to return something other than
the actual name of the enum.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133318012
---
 java/google/registry/rdap/RdapJsonFormatter.java | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/java/google/registry/rdap/RdapJsonFormatter.java b/java/google/registry/rdap/RdapJsonFormatter.java
index c81afe1da..01191304c 100644
--- a/java/google/registry/rdap/RdapJsonFormatter.java
+++ b/java/google/registry/rdap/RdapJsonFormatter.java
@@ -133,8 +133,7 @@ public class RdapJsonFormatter {
       this.rfc7483String = rfc7483String;
     }
 
-    @Override
-    public String toString() {
+    public String getDisplayName() {
       return rfc7483String;
     }
   }
@@ -211,8 +210,7 @@ public class RdapJsonFormatter {
       this.rfc7483String = rfc7483String;
     }
 
-    @Override
-    public String toString() {
+    public String getDisplayName() {
       return rfc7483String;
     }
   }
@@ -821,7 +819,7 @@ public class RdapJsonFormatter {
   private static ImmutableMap<String, Object> makeEvent(
       RdapEventAction eventAction, @Nullable String eventActor, DateTime eventDate) {
     ImmutableMap.Builder<String, Object> builder = new ImmutableMap.Builder<>();
-    builder.put("eventAction", eventAction.toString());
+    builder.put("eventAction", eventAction.getDisplayName());
     if (eventActor != null) {
       builder.put("eventActor", eventActor);
     }
@@ -901,7 +899,11 @@ public class RdapJsonFormatter {
     return FluentIterable
         .from(statusValues)
         .transform(Functions.forMap(statusToRdapStatusMap, RdapStatus.OBSCURED))
-        .transform(Functions.toStringFunction())
+        .transform(new Function<RdapStatus, String>() {
+          @Override
+          public String apply(RdapStatus status) {
+            return status.getDisplayName();
+          }})
         .toSortedSet(Ordering.natural())
         .asList();
   }