mirror of
https://github.com/google/nomulus.git
synced 2025-08-05 01:11:50 +02:00
Rationalize logging statements across codebase
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
This commit is contained in:
parent
f22a42cd42
commit
81dc2bbbc3
47 changed files with 172 additions and 154 deletions
|
@ -136,8 +136,8 @@ public final class NordnVerifyAction implements Runnable {
|
|||
logger.warning(result.toString());
|
||||
break;
|
||||
default:
|
||||
logger.warningfmt("LORDN verify task %s: Unexpected outcome: %s",
|
||||
actionLogId, result.toString());
|
||||
logger.warningfmt(
|
||||
"LORDN verify task %s: Unexpected outcome: %s", actionLogId, result.toString());
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
|
@ -56,7 +56,8 @@ public final class TmchSmdrlAction implements Runnable {
|
|||
}
|
||||
SignedMarkRevocationList smdrl = SmdrlCsvParser.parse(lines);
|
||||
smdrl.save();
|
||||
logger.infofmt("Inserted %,d smd revocations into Datastore, created at %s",
|
||||
logger.infofmt(
|
||||
"Inserted %,d smd revocations into Datastore, created at %s",
|
||||
smdrl.size(), smdrl.getCreationTime());
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue