Rationalize logging statements across codebase

This fixes up the following problems:
1. Using string concatenation instead of the formatting variant methods.
2. Logging or swallowing exception messages without logging the exception
   itself (this swallows the stack trace).
3. Unnecessary logging on re-thrown exceptions.
4. Unnecessary use of formatting variant methods when not necessary.
5. Complicated logging statements involving significant processing not being
   wrapped inside of a logging level check.
6. Redundant logging both of an exception itself and its message (this is
   unnecessary duplication).
7. Use of the base Logger class instead of our FormattingLogger class.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=182419837
This commit is contained in:
mcilwain 2018-01-18 12:27:06 -08:00 committed by Ben McIlwain
parent f22a42cd42
commit 81dc2bbbc3
47 changed files with 172 additions and 154 deletions

View file

@ -14,10 +14,9 @@
package google.registry.dns.writer;
import com.google.common.base.Joiner;
import google.registry.util.FormattingLogger;
import java.util.HashSet;
import java.util.Set;
import java.util.logging.Logger;
import javax.inject.Inject;
/**
@ -33,7 +32,7 @@ public final class VoidDnsWriter extends BaseDnsWriter {
*/
public static final String NAME = "VoidDnsWriter";
private static final Logger logger = Logger.getLogger(VoidDnsWriter.class.getName());
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
private final Set<String> names = new HashSet<>();
@ -52,7 +51,7 @@ public final class VoidDnsWriter extends BaseDnsWriter {
@Override
protected void commitUnchecked() {
logger.warning("Ignoring DNS zone updates! No DnsWriterFactory implementation specified!\n"
+ Joiner.on('\n').join(names));
logger.warningfmt(
"No DnsWriterFactory implementation specified; ignoring names to commit: %s", names);
}
}