zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-07 21:15:42 +02:00
Code Issues Projects Releases Packages Wiki Activity

Instead of calling Subject.actual(), store the actual value in a field, and read that.

Browse source 
actual() is being removed.

More information:
  []

Tested:
    TAP --sample ran all affected tests and none failed
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=247415370
This commit is contained in:
cpovirk 2019-05-09 06:47:46 -07:00 • committed by jianglai
parent 40658835f5
commit 7e544fd641
9 changed files with 107 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

18
javatests/google/registry/testing/AbstractDomainBaseSubject.java
View file

@ -28,14 +28,17 @@ public abstract class AbstractDomainBaseSubject
<T extends DomainBase, S extends AbstractDomainBaseSubject<T, S>>
extends AbstractEppResourceSubject<T, S> {
private final T actual;
public AbstractDomainBaseSubject(FailureMetadata failureMetadata, T subject) {
super(failureMetadata, subject);
this.actual = subject;
}
public And<S> hasFullyQualifiedDomainName(String fullyQualifiedDomainName) {
return hasValue(
fullyQualifiedDomainName,
actual().getFullyQualifiedDomainName(),
actual.getFullyQualifiedDomainName(),
"has fullyQualifiedDomainName");
}
@ -44,26 +47,23 @@ public abstract class AbstractDomainBaseSubject
}
public And<S> hasExactlyDsData(Set<DelegationSignerData> dsData) {
return hasValue(dsData, actual().getDsData(), "has dsData");
return hasValue(dsData, actual.getDsData(), "has dsData");
}
public And<S> hasNumDsData(int num) {
return hasValue(num, actual().getDsData().size(), "has num dsData");
return hasValue(num, actual.getDsData().size(), "has num dsData");
}
public And<S> hasLaunchNotice(LaunchNotice launchNotice) {
return hasValue(launchNotice, actual().getLaunchNotice(), "has launchNotice");
return hasValue(launchNotice, actual.getLaunchNotice(), "has launchNotice");
}
public And<S> hasAuthInfoPwd(String pw) {
AuthInfo authInfo = actual().getAuthInfo();
AuthInfo authInfo = actual.getAuthInfo();
return hasValue(pw, authInfo == null ? null : authInfo.getPw().getValue(), "has auth info pw");
}
public And<S> hasCurrentSponsorClientId(String clientId) {
return hasValue(
clientId,
actual().getCurrentSponsorClientId(),
"has currentSponsorClientId");
return hasValue(clientId, actual.getCurrentSponsorClientId(), "has currentSponsorClientId");
}
}