zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

Automatically refactor more exception testing to use new JUnit rules

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178911894
This commit is contained in:
mcilwain 2017-08-14 09:20:03 -04:00 • committed by Ben McIlwain
parent 36ad38e5df
commit 7dc224627f
125 changed files with 1970 additions and 1982 deletions
Download patch file Download diff file Expand all files Collapse all files

113
javatests/google/registry/util/SqlTemplateTest.java
View file

@ -15,10 +15,9 @@
package google.registry.util;
import static com.google.common.truth.Truth.assertThat;
import static google.registry.testing.JUnitBackports.expectThrows;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
@ -26,9 +25,6 @@ import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
public class SqlTemplateTest {
@Rule
public final ExpectedException thrown = ExpectedException.none();
@Test
public void testFillSqlTemplate() throws Exception {
assertThat(
@ -52,98 +48,99 @@ public class SqlTemplateTest {
@Test
public void testFillSqlTemplate_substitutionButNoVariables() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Not found in template: ONE");
SqlTemplate.create("")
.put("ONE", "1")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class, () -> SqlTemplate.create("").put("ONE", "1").build());
assertThat(thrown).hasMessageThat().contains("Not found in template: ONE");
}
@Test
public void testFillSqlTemplate_substitutionButMissingVariables() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Not found in template: TWO");
SqlTemplate.create("%ONE%")
.put("ONE", "1")
.put("TWO", "2")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("%ONE%").put("ONE", "1").put("TWO", "2").build());
assertThat(thrown).hasMessageThat().contains("Not found in template: TWO");
}
@Test
public void testFillSqlTemplate_sameKeyTwice_failsEarly() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("");
SqlTemplate.create("%ONE%")
.put("ONE", "1")
.put("ONE", "2");
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("%ONE%").put("ONE", "1").put("ONE", "2"));
assertThat(thrown).hasMessageThat().contains("");
}
@Test
public void testFillSqlTemplate_variablesButNotEnoughSubstitutions() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("%TWO% found in template but no substitution");
SqlTemplate.create("%ONE% %TWO%")
.put("ONE", "1")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("%ONE% %TWO%").put("ONE", "1").build());
assertThat(thrown).hasMessageThat().contains("%TWO% found in template but no substitution");
}
@Test
public void testFillSqlTemplate_mismatchedVariableAndSubstitution() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("%TWO% found in template but no substitution");
SqlTemplate.create("%TWO%")
.put("TOO", "2")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("%TWO%").put("TOO", "2").build());
assertThat(thrown).hasMessageThat().contains("%TWO% found in template but no substitution");
}
@Test
public void testFillSqlTemplate_missingKeyVals_whatsThePoint() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("%TWO% found in template but no substitution");
SqlTemplate.create("%TWO%")
.build();
IllegalArgumentException thrown =
expectThrows(IllegalArgumentException.class, () -> SqlTemplate.create("%TWO%").build());
assertThat(thrown).hasMessageThat().contains("%TWO% found in template but no substitution");
}
@Test
public void testFillSqlTemplate_lowercaseKey_notAllowed() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Bad substitution key: test");
SqlTemplate.create("%test%")
.put("test", "hello world")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("%test%").put("test", "hello world").build());
assertThat(thrown).hasMessageThat().contains("Bad substitution key: test");
}
@Test
public void testFillSqlTemplate_substitution_disallowsSingleQuotes() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Illegal characters in foo'bar");
SqlTemplate.create("The words are '%LOS%' and baz")
.put("LOS", "foo'bar");
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("The words are '%LOS%' and baz").put("LOS", "foo'bar"));
assertThat(thrown).hasMessageThat().contains("Illegal characters in foo'bar");
}
@Test
public void testFillSqlTemplate_substitution_disallowsDoubleQuotes() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Illegal characters in foo\"bar");
SqlTemplate.create("The words are '%LOS%' and baz")
.put("LOS", "foo\"bar");
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() -> SqlTemplate.create("The words are '%LOS%' and baz").put("LOS", "foo\"bar"));
assertThat(thrown).hasMessageThat().contains("Illegal characters in foo\"bar");
}
@Test
public void testFillSqlTemplate_quoteMismatch_throwsError() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Quote mismatch: \"%LOS%'");
SqlTemplate.create("The words are \"%LOS%' and baz")
.put("LOS", "foobar")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() ->
SqlTemplate.create("The words are \"%LOS%' and baz").put("LOS", "foobar").build());
assertThat(thrown).hasMessageThat().contains("Quote mismatch: \"%LOS%'");
}
@Test
public void testFillSqlTemplate_extendedQuote_throwsError() throws Exception {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Quote mismatch: '%LOS%");
SqlTemplate.create("The words are '%LOS%-lol' and baz")
.put("LOS", "roid")
.build();
IllegalArgumentException thrown =
expectThrows(
IllegalArgumentException.class,
() ->
SqlTemplate.create("The words are '%LOS%-lol' and baz").put("LOS", "roid").build());
assertThat(thrown).hasMessageThat().contains("Quote mismatch: '%LOS%");
}
}