zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 00:17:20 +02:00
Code Issues Projects Releases Packages Wiki Activity

De-duplicate flow documentation error reasons on a per-code basis

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=250894847
This commit is contained in:
gbrodman 2019-05-31 09:00:17 -07:00 • committed by Ben McIlwain
parent e489539df4
commit 79bcb227be
2 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/flows.md
View file

@ -27,7 +27,6 @@ An EPP flow that creates a new contact.
* Internationalized postal infos can only contain ASCII characters. * Internationalized postal infos can only contain ASCII characters.
* 2302 * 2302
* Resource with this id already exists. * Resource with this id already exists.
* Resource with this id already exists.
* 2306 * 2306
* Declining contact disclosure is disallowed by server policy. * Declining contact disclosure is disallowed by server policy.
@ -342,7 +341,6 @@ An EPP flow that creates a new domain resource.
* Registrar must be active in order to perform this operation. * Registrar must be active in order to perform this operation.
* 2302 * 2302
* Resource with this id already exists. * Resource with this id already exists.
* Resource with this id already exists.
* 2303 * 2303
* Resource linked to this domain does not exist. * Resource linked to this domain does not exist.
* 2304 * 2304
@ -825,7 +823,6 @@ allows creating a host name, and if necessary enqueues tasks to update DNS.
* Host names must be puny-coded. * Host names must be puny-coded.
* 2302 * 2302
* Resource with this id already exists. * Resource with this id already exists.
* Resource with this id already exists.
* 2303 * 2303
* Superordinate domain for this hostname does not exist. * Superordinate domain for this hostname does not exist.
* 2304 * 2304

19
java/google/registry/documentation/MarkdownDocumentationFormatter.java
View file

@ -163,15 +163,18 @@ public final class MarkdownDocumentationFormatter {
for (Long code : flowDoc.getErrorsByCode().keySet()) { for (Long code : flowDoc.getErrorsByCode().keySet()) {
output.append(String.format("* %d\n", code)); output.append(String.format("* %d\n", code));
flowDoc.getErrorsByCode().get(code).stream()
.map(ErrorCase::getReason)
.distinct()
.forEach(
reason -> {
output.append(" * ");
String wrappedReason = reflow(fixHtml(reason), LINE_WIDTH - 8);
for (ErrorCase error : flowDoc.getErrorsByCode().get(code)) { // Replace internal newlines with indentation and strip the final newline.
output.append(" * "); output.append(wrappedReason.trim().replace("\n", "\n" + INDENT8));
String wrappedReason = reflow(fixHtml(error.getReason()), LINE_WIDTH - 8); output.append('\n');
});
// Replace internal newlines with indentation and strip the final newline.
output.append(wrappedReason.trim().replace("\n", "\n" + INDENT8));
output.append('\n');
}
} }
output.append('\n'); output.append('\n');
} }