zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-30 12:07:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Implement 10 min backoff for failed async deletes

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=117945626
This commit is contained in:
ctingue 2016-03-23 10:45:43 -07:00 • committed by Justine Tunney
parent 85911e0b95
commit 79b2d5a990
3 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
java/com/google/domain/registry/config/RegistryConfig.java
View file

@ -256,4 +256,12 @@ public interface RegistryConfig {
* committed, and could potentially miss the reference.
*/
public Duration getAsyncDeleteFlowMapreduceDelay();
/**
* Returns the amount of time to back off following an async delete flow task failure.
*
* This should be ~orders of magnitude larger than the rate on the queue, in order to prevent
* the logs from filling up with unnecessarily failures.
*/
public Duration getAsyncDeleteFlowFailureBackoff();
}

5
java/com/google/domain/registry/config/TestRegistryConfig.java
View file

@ -193,4 +193,9 @@ public class TestRegistryConfig implements RegistryConfig {
public Duration getAsyncDeleteFlowMapreduceDelay() {
return Duration.standardSeconds(90);
}
@Override
public Duration getAsyncDeleteFlowFailureBackoff() {
return Duration.standardMinutes(10);
}
}

6
java/com/google/domain/registry/flows/async/AsyncFlowUtils.java
View file

@ -18,11 +18,13 @@ import static com.google.domain.registry.request.Actions.getPathForAction;
import com.google.appengine.api.taskqueue.Queue;
import com.google.appengine.api.taskqueue.QueueFactory;
import com.google.appengine.api.taskqueue.RetryOptions;
import com.google.appengine.api.taskqueue.TaskHandle;
import com.google.appengine.api.taskqueue.TaskOptions;
import com.google.appengine.api.taskqueue.TaskOptions.Method;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableMap;
import com.google.domain.registry.config.RegistryEnvironment;
import com.google.domain.registry.mapreduce.MapreduceAction;
import com.google.domain.registry.util.FormattingLogger;
@ -48,8 +50,12 @@ public final class AsyncFlowUtils {
Queue queue = QueueFactory.getQueue(ASYNC_FLOW_QUEUE_NAME);
String path = getPathForAction(action);
logger.infofmt("Enqueueing async mapreduce action with path %s and params %s", path, params);
// Aggressively back off if the task fails, to minimize flooding the logs.
RetryOptions retryOptions = RetryOptions.Builder.withMinBackoffSeconds(
RegistryEnvironment.get().config().getAsyncDeleteFlowFailureBackoff().getStandardSeconds());
TaskOptions options = TaskOptions.Builder
.withUrl(path)
.retryOptions(retryOptions)
.countdownMillis(executionDelay.getMillis())
.method(Method.GET);
for (Entry<String, String> entry : params.entrySet()) {