diff --git a/java/google/registry/flows/domain/DomainApplicationCreateFlow.java b/java/google/registry/flows/domain/DomainApplicationCreateFlow.java index aae3207ac..716e5fa20 100644 --- a/java/google/registry/flows/domain/DomainApplicationCreateFlow.java +++ b/java/google/registry/flows/domain/DomainApplicationCreateFlow.java @@ -353,7 +353,6 @@ public final class DomainApplicationCreateFlow extends Flow implements Transacti years, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } } diff --git a/java/google/registry/flows/domain/DomainCreateFlow.java b/java/google/registry/flows/domain/DomainCreateFlow.java index e0c13b99e..812deaac3 100644 --- a/java/google/registry/flows/domain/DomainCreateFlow.java +++ b/java/google/registry/flows/domain/DomainCreateFlow.java @@ -404,7 +404,6 @@ public class DomainCreateFlow extends Flow implements TransactionalFlow { years, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } } diff --git a/java/google/registry/flows/domain/DomainDeleteFlow.java b/java/google/registry/flows/domain/DomainDeleteFlow.java index 9435bf43a..4f60ea191 100644 --- a/java/google/registry/flows/domain/DomainDeleteFlow.java +++ b/java/google/registry/flows/domain/DomainDeleteFlow.java @@ -198,7 +198,6 @@ public final class DomainDeleteFlow extends Flow implements TransactionalFlow { if (extraFlowLogic.isPresent()) { extraFlowLogic.get().performAdditionalDomainDeleteLogic( existingResource, clientId, now, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } } diff --git a/java/google/registry/flows/domain/DomainRenewFlow.java b/java/google/registry/flows/domain/DomainRenewFlow.java index 10ccd2666..79496ec5b 100644 --- a/java/google/registry/flows/domain/DomainRenewFlow.java +++ b/java/google/registry/flows/domain/DomainRenewFlow.java @@ -161,7 +161,6 @@ public final class DomainRenewFlow extends Flow implements TransactionalFlow { if (extraFlowLogic.isPresent()) { extraFlowLogic.get().performAdditionalDomainRenewLogic( existingDomain, clientId, now, years, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } DomainResource newDomain = existingDomain.asBuilder() .setRegistrationExpirationTime(newExpirationTime) diff --git a/java/google/registry/flows/domain/DomainRestoreRequestFlow.java b/java/google/registry/flows/domain/DomainRestoreRequestFlow.java index 6b02e8d4b..f85838f06 100644 --- a/java/google/registry/flows/domain/DomainRestoreRequestFlow.java +++ b/java/google/registry/flows/domain/DomainRestoreRequestFlow.java @@ -155,7 +155,6 @@ public final class DomainRestoreRequestFlow extends Flow implements Transactiona if (extraFlowLogic.isPresent()) { extraFlowLogic.get().performAdditionalDomainRestoreLogic( existingDomain, clientId, now, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } DomainResource newDomain = performRestore(existingDomain, newExpirationTime, autorenewEvent, autorenewPollMessage); diff --git a/java/google/registry/flows/domain/DomainTransferRequestFlow.java b/java/google/registry/flows/domain/DomainTransferRequestFlow.java index ac8c3b33d..89d7bc804 100644 --- a/java/google/registry/flows/domain/DomainTransferRequestFlow.java +++ b/java/google/registry/flows/domain/DomainTransferRequestFlow.java @@ -372,7 +372,6 @@ public final class DomainTransferRequestFlow extends Flow implements Transaction if (extraFlowLogic.isPresent()) { extraFlowLogic.get().performAdditionalDomainTransferLogic( existingDomain, gainingClientId, now, years, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } } diff --git a/java/google/registry/flows/domain/DomainUpdateFlow.java b/java/google/registry/flows/domain/DomainUpdateFlow.java index a530b3255..30ec444bb 100644 --- a/java/google/registry/flows/domain/DomainUpdateFlow.java +++ b/java/google/registry/flows/domain/DomainUpdateFlow.java @@ -333,7 +333,6 @@ public final class DomainUpdateFlow extends Flow implements TransactionalFlow { if (extraFlowLogic.isPresent()) { extraFlowLogic.get().performAdditionalDomainUpdateLogic( existingDomain, clientId, now, eppInput, historyEntry); - extraFlowLogic.get().commitAdditionalLogicChanges(); } } } diff --git a/java/google/registry/flows/domain/RegistryExtraFlowLogic.java b/java/google/registry/flows/domain/RegistryExtraFlowLogic.java index 088e7749e..a39eff57d 100644 --- a/java/google/registry/flows/domain/RegistryExtraFlowLogic.java +++ b/java/google/registry/flows/domain/RegistryExtraFlowLogic.java @@ -63,12 +63,7 @@ public interface RegistryExtraFlowLogic { int years, EppInput eppInput) throws EppException; - /** - * Performs additional tasks required for a create command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is - * called. - */ + /** Performs additional tasks required for a create command. */ public void performAdditionalDomainCreateLogic( DomainResource domain, String clientId, @@ -77,12 +72,7 @@ public interface RegistryExtraFlowLogic { EppInput eppInput, HistoryEntry historyEntry) throws EppException; - /** - * Performs additional tasks required for a delete command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is - * called. - */ + /** Performs additional tasks required for a delete command. */ public void performAdditionalDomainDeleteLogic( DomainResource domain, String clientId, @@ -102,12 +92,7 @@ public interface RegistryExtraFlowLogic { int years, EppInput eppInput) throws EppException; - /** - * Performs additional tasks required for a renew command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is - * called. - */ + /** Performs additional tasks required for a renew command. */ public void performAdditionalDomainRenewLogic( DomainResource domain, String clientId, @@ -116,12 +101,7 @@ public interface RegistryExtraFlowLogic { EppInput eppInput, HistoryEntry historyEntry) throws EppException; - /** - * Performs additional tasks required for a restore command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is - * called. - */ + /** Performs additional tasks required for a restore command. */ public void performAdditionalDomainRestoreLogic( DomainResource domain, String clientId, @@ -129,12 +109,7 @@ public interface RegistryExtraFlowLogic { EppInput eppInput, HistoryEntry historyEntry) throws EppException; - /** - * Performs additional tasks required for a transfer command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is - * called. - */ + /** Performs additional tasks required for a transfer command. */ public void performAdditionalDomainTransferLogic( DomainResource domain, String clientId, @@ -154,19 +129,11 @@ public interface RegistryExtraFlowLogic { DateTime asOfDate, EppInput eppInput) throws EppException; - /** - * Performs additional tasks required for an update command. - * - *
Any changes should not be persisted to Datastore until commitAdditionalLogicChanges is
- * called.
- */
+ /** Performs additional tasks required for an update command. */
public void performAdditionalDomainUpdateLogic(
DomainResource domain,
String clientId,
DateTime asOfDate,
EppInput eppInput,
HistoryEntry historyEntry) throws EppException;
-
- /** Commits any changes made as a result of a call to one of the performXXX methods. */
- public void commitAdditionalLogicChanges();
}
diff --git a/javatests/google/registry/flows/FlowTestCase.java b/javatests/google/registry/flows/FlowTestCase.java
index 13f4345a2..ef6e048a9 100644
--- a/javatests/google/registry/flows/FlowTestCase.java
+++ b/javatests/google/registry/flows/FlowTestCase.java
@@ -118,7 +118,7 @@ public abstract class FlowTestCase