From 77c62219d5e165c25a39c08424e50e7709caf170 Mon Sep 17 00:00:00 2001 From: Ben McIlwain Date: Mon, 21 Aug 2017 06:40:54 -0700 Subject: [PATCH] Rename set to depset in .bzl and BUILD files `set` is a deprecated alias for `depset` and will be removed soon. This change does not change the behavior in any way. More information: https://docs.google.com/document/d/1oeXoXGOsaUlre1NCap8RJDNNXX1x6RiXeJKhEzl5-qk Tested: tap_presubmit Some tests failed; test failures are believed to be unrelated to this CL ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=165921608 --- java/google/registry/builddefs/defs.bzl | 2 +- java/google/registry/builddefs/zip_file.bzl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/google/registry/builddefs/defs.bzl b/java/google/registry/builddefs/defs.bzl index 1bab65fb3..5f2d8a4db 100644 --- a/java/google/registry/builddefs/defs.bzl +++ b/java/google/registry/builddefs/defs.bzl @@ -42,7 +42,7 @@ def collect_runfiles(targets): Returns: A list of Bazel files. """ - data = set() + data = depset() for target in targets: if hasattr(target, "runfiles"): data += target.runfiles.files diff --git a/java/google/registry/builddefs/zip_file.bzl b/java/google/registry/builddefs/zip_file.bzl index 9ef5905ec..288948e35 100644 --- a/java/google/registry/builddefs/zip_file.bzl +++ b/java/google/registry/builddefs/zip_file.bzl @@ -132,7 +132,7 @@ def _zip_file(ctx): if (s.startswith('/') or s.endswith('/') or d.startswith('/') or d.endswith('/')): fail('mappings should not begin or end with slash') - srcs = set() + srcs = depset() srcs += ctx.files.srcs srcs += ctx.files.data srcs += collect_runfiles(ctx.attr.data) @@ -150,7 +150,7 @@ def _zip_file(ctx): for dep in ctx.attr.deps] cmd += ['rm %s' % filename for filename in ctx.attr.exclude] cmd += ['mkdir -p "${tmp}/%s"' % zip_path - for zip_path in set( + for zip_path in depset( [zip_path[:zip_path.rindex('/')] for _, zip_path in mapped if '/' in zip_path])] cmd += ['ln -sf "${repo}/%s" "${tmp}/%s"' % (path, zip_path) @@ -177,7 +177,7 @@ def _zip_file(ctx): mnemonic='zip', progress_message='Creating zip with %d inputs %s' % ( len(inputs), ctx.label)) - return struct(files=set([ctx.outputs.out]), zip_file=ctx.outputs.out) + return struct(files=depset([ctx.outputs.out]), zip_file=ctx.outputs.out) def _map_sources(ctx, srcs, mappings): """Calculates paths in zip file for srcs."""