zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-11 06:54:46 +02:00
Code Issues Projects Releases Packages Wiki Activity

Catch all errors in WhoisHttpAction

Browse source 
Uncaught exception skips the call to metricBuilder.setNumResults()
and triggers an AutoValue builder exception from the finally block.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=228936029
This commit is contained in:
weiminyu 2019-01-11 13:34:09 -08:00 • committed by Ben McIlwain
parent 170980db2f
commit 773af1da35
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/whois/WhoisHttpAction.java
View file

@ -28,6 +28,7 @@ import static javax.servlet.http.HttpServletResponse.SC_OK;
import com.google.common.base.Joiner;
import com.google.common.base.Splitter;
import com.google.common.base.Throwables;
import com.google.common.flogger.FluentLogger;
import google.registry.config.RegistryConfig.Config;
import google.registry.request.Action;
@ -37,7 +38,6 @@ import google.registry.request.auth.Auth;
import google.registry.util.Clock;
import google.registry.whois.WhoisMetrics.WhoisMetric;
import google.registry.whois.WhoisResponse.WhoisResponseResults;
import java.io.IOException;
import java.io.StringReader;
import java.io.UnsupportedEncodingException;
import java.net.URLDecoder;
@ -158,9 +158,10 @@ public final class WhoisHttpAction implements Runnable {
metricBuilder.setStatus(e.getStatus());
metricBuilder.setNumResults(0);
sendResponse(e.getStatus(), e);
} catch (IOException e) {
} catch (Throwable e) {
metricBuilder.setStatus(SC_INTERNAL_SERVER_ERROR);
metricBuilder.setNumResults(0);
Throwables.throwIfUnchecked(e);
throw new RuntimeException(e);
} finally {
whoisMetrics.recordWhoisMetric(metricBuilder.build());