zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor ICANN reporting and billing into common package

Browse source 
This moves the default yearMonth logic into a common ReportingModule, rather than the coarse-scoped BackendModule, which may not want the default parameter extraction logic, as well as moving the 'yearMonth' parameter constant to the common package it's used in. This also provides a basis for future consolidation of the ReportingEmailUtils and BillingEmailUtils classes, which have modest overlap.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=183130311
This commit is contained in:
larryruili 2018-01-24 13:16:51 -08:00 • committed by Ben McIlwain
parent 9d532cb507
commit 74ced1e907
71 changed files with 233 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

16
java/google/registry/config/RegistryConfig.java
View file

@ -470,7 +470,7 @@ public final class RegistryConfig {
/**
* Returns the name of the GCS bucket for storing Beam templates and results.
*
* @see google.registry.billing.GenerateInvoicesAction
* @see google.registry.reporting.billing.GenerateInvoicesAction
*/
@Provides
@Config("apacheBeamBucket")
@ -481,7 +481,7 @@ public final class RegistryConfig {
/**
* Returns the URL of the GCS location for storing Apache Beam related objects.
*
* @see google.registry.billing.GenerateInvoicesAction
* @see google.registry.reporting.billing.GenerateInvoicesAction
*/
@Provides
@Config("apacheBeamBucketUrl")
@ -492,7 +492,7 @@ public final class RegistryConfig {
/**
* Returns the URL of the GCS location for storing the monthly invoicing Beam template.
*
* @see google.registry.billing.GenerateInvoicesAction
* @see google.registry.reporting.billing.GenerateInvoicesAction
* @see google.registry.beam.InvoicingPipeline
*/
@Provides
@ -518,7 +518,7 @@ public final class RegistryConfig {
* Returns the Google Cloud Storage bucket for ICANN transaction and activity reports to
* be uploaded.
*
* @see google.registry.reporting.IcannReportingUploadAction
* @see google.registry.reporting.icann.IcannReportingUploadAction
*/
@Provides
@Config("icannReportingBucket")
@ -529,7 +529,7 @@ public final class RegistryConfig {
/**
* Returns the URL we send HTTP PUT requests for ICANN monthly transactions reports.
*
* @see google.registry.reporting.IcannHttpReporter
* @see google.registry.reporting.icann.IcannHttpReporter
*/
@Provides
@Config("icannTransactionsReportingUploadUrl")
@ -540,7 +540,7 @@ public final class RegistryConfig {
/**
* Returns the URL we send HTTP PUT requests for ICANN monthly activity reports.
*
* @see google.registry.reporting.IcannHttpReporter
* @see google.registry.reporting.icann.IcannHttpReporter
*/
@Provides
@Config("icannActivityReportingUploadUrl")
@ -768,7 +768,7 @@ public final class RegistryConfig {
* <p>This allows us to easily verify the success or failure of periodic tasks by passively
* checking e-mail.
*
* @see google.registry.reporting.ReportingEmailUtils
* @see google.registry.reporting.icann.ReportingEmailUtils
* @see google.registry.billing.BillingEmailUtils
*/
@Provides
@ -780,7 +780,7 @@ public final class RegistryConfig {
/**
* Returns the email address we send emails from.
*
* @see google.registry.reporting.ReportingEmailUtils
* @see google.registry.reporting.icann.ReportingEmailUtils
* @see google.registry.billing.BillingEmailUtils
*/