zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-14 16:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Handle nullness properly in some message/flow/poll code

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=127543268
This commit is contained in:
mcilwain 2016-07-15 08:39:25 -07:00 • committed by Ben McIlwain
parent eed319990a
commit 71ab4a648b
7 changed files with 27 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/model/eppoutput/EppResponse.java
View file

@ -47,6 +47,7 @@ import google.registry.model.poll.PendingActionNotificationResponse.ContactPendi
import google.registry.model.poll.PendingActionNotificationResponse.DomainPendingActionNotificationResponse;
import google.registry.model.transfer.TransferResponse.ContactTransferResponse;
import google.registry.model.transfer.TransferResponse.DomainTransferResponse;
import javax.annotation.Nullable;
import javax.xml.bind.annotation.XmlElement;
import javax.xml.bind.annotation.XmlElementRef;
import javax.xml.bind.annotation.XmlElementRefs;
@ -187,12 +188,12 @@ public class EppResponse extends ImmutableObject implements ResponseOrGreeting {
return this;
}
public Builder setResData(ImmutableList<? extends ResponseData> resData) {
public Builder setResData(@Nullable ImmutableList<? extends ResponseData> resData) {
getInstance().resData = resData;
return this;
}
public Builder setExtensions(ImmutableList<? extends ResponseExtension> extensions) {
public Builder setExtensions(@Nullable ImmutableList<? extends ResponseExtension> extensions) {
getInstance().extensions = extensions;
return this;
}

11
java/google/registry/model/poll/MessageQueueInfo.java
View file

@ -14,7 +14,10 @@
package google.registry.model.poll;
import static com.google.common.base.Preconditions.checkNotNull;
import google.registry.model.ImmutableObject;
import javax.annotation.Nullable;
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
import org.joda.time.DateTime;
@ -54,15 +57,15 @@ public class MessageQueueInfo extends ImmutableObject {
}
public static MessageQueueInfo create(
DateTime queueDate,
String msg,
@Nullable DateTime queueDate,
@Nullable String msg,
Integer queueLength,
String messageId) {
MessageQueueInfo instance = new MessageQueueInfo();
instance.queueDate = queueDate;
instance.msg = msg;
instance.queueLength = queueLength;
instance.messageId = messageId;
instance.queueLength = checkNotNull(queueLength);
instance.messageId = checkNotNull(messageId);
return instance;
}
}