zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-27 14:54:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Handle nullness properly in some message/flow/poll code

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=127543268
This commit is contained in:
mcilwain 2016-07-15 08:39:25 -07:00 • committed by Ben McIlwain
parent eed319990a
commit 71ab4a648b
7 changed files with 27 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/flows/Flow.java
View file

@ -27,6 +27,7 @@ import google.registry.model.eppoutput.Result;
import java.util.Collections;
import java.util.HashSet;
import java.util.Set;
import javax.annotation.Nullable;
import org.joda.time.DateTime;
/**
@ -78,8 +79,8 @@ public abstract class Flow {
protected EppOutput createOutput(
Result.Code code,
ResponseData responseData,
ImmutableList<? extends ResponseExtension> extensions) {
@Nullable ResponseData responseData,
@Nullable ImmutableList<? extends ResponseExtension> extensions) {
return EppOutput.create(new EppResponse.Builder()
.setTrid(trid)
.setResult(Result.create(code))

2
java/google/registry/flows/ResourceDeleteFlow.java
View file

@ -25,6 +25,7 @@ import google.registry.model.eppoutput.EppOutput;
import google.registry.model.eppoutput.EppResponse.ResponseExtension;
import google.registry.model.eppoutput.Result.Code;
import java.util.Set;
import javax.annotation.Nullable;
/**
* An EPP flow that deletes an {@link EppResource}.
@ -58,6 +59,7 @@ public abstract class ResourceDeleteFlow<R extends EppResource, C extends Single
}
/** Subclasses can override this to return response extensions. */
@Nullable
protected ImmutableList<? extends ResponseExtension> getDeleteResponseExtensions() {
return null;
}

5
java/google/registry/flows/poll/PollFlow.java
View file

@ -31,6 +31,7 @@ import google.registry.model.eppoutput.Result;
import google.registry.model.poll.MessageQueueInfo;
import google.registry.model.poll.PollMessage;
import java.util.List;
import javax.annotation.Nullable;
/** Base class of EPP Poll command flows. Mostly provides datastore helper methods. */
public abstract class PollFlow extends LoggedInFlow {
@ -74,8 +75,8 @@ public abstract class PollFlow extends LoggedInFlow {
protected EppOutput createOutput(
Result.Code code,
MessageQueueInfo messageQueueInfo,
ImmutableList<ResponseData> responseData,
ImmutableList<ResponseExtension> responseExtensions) {
@Nullable ImmutableList<ResponseData> responseData,
@Nullable ImmutableList<ResponseExtension> responseExtensions) {
return EppOutput.create(new EppResponse.Builder()
.setTrid(trid)
.setResult(Result.create(code))