zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Migrates users from the unitless, ambiguous plus(long) and minus(long) methods on various Joda-Time APIs to their Duration-accepting overloads.

Browse source 
​
This makes the units explicit, which prevents confusion and bugs.

More information: []
Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172455602
This commit is contained in:
kak 2017-10-17 05:57:48 -07:00 • committed by jianglai
parent 108deb7f9d
commit 6f9b039e72
4 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
javatests/google/registry/tools/CreateTldCommandTest.java
View file

@ -37,6 +37,7 @@ import java.io.PrintStream;
import java.math.BigDecimal;
import org.joda.money.Money;
import org.joda.time.DateTime;
import org.joda.time.Duration;
import org.joda.time.Interval;
import org.junit.Before;
import org.junit.Test;
@ -333,7 +334,9 @@ public class CreateTldCommandTest extends CommandTestCase<CreateTldCommand> {
IllegalArgumentException.class,
"Don't pass both --initial_tld_state and --tld_state_transitions");
runCommandForced(
String.format("--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE", now, now.plus(1)),
String.format(
"--tld_state_transitions=%s=PREDELEGATION,%s=SUNRISE",
now, now.plus(Duration.millis(1))),
"--initial_tld_state=GENERAL_AVAILABILITY",
"--dns_writers=VoidDnsWriter",
"xn--q9jyb4c");