Make javadoc <p> style guide compliant

This led to confusion for an open source contributor about how to format
code. We don't want to be like, "do as I say, not as I do."

https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=122589700

java/google/registry/model/domain/DomainBase.java

@@ -59,9 +59,9 @@ public abstract class DomainBase extends EppResource {
 
   /**
    * Fully qualified domain name (puny-coded), which serves as the foreign key for this domain.
-   * <p>
-   * This is only unique in the sense that for any given lifetime specified as the time range from
-   * (creationTime, deletionTime) there can only be one domain in the datastore with this name.
+   *
+   * <p>This is only unique in the sense that for any given lifetime specified as the time range
+   * from (creationTime, deletionTime) there can only be one domain in the datastore with this name.
    * However, there can be many domains with the same name and non-overlapping lifetimes.
    *
    * @invariant fullyQualifiedDomainName == fullyQualifiedDomainName.toLowerCase()
@@ -83,8 +83,8 @@ public abstract class DomainBase extends EppResource {
 
   /**
    * Associated contacts for the domain (other than registrant).
-   * <p>
-   * This field is marked with {@literal @}Ignore so that {@link DomainBase} subclasses won't
+   *
+   * <p>This field is marked with {@literal @}Ignore so that {@link DomainBase} subclasses won't
    * persist it. Instead, the data in this field and in the {@link #registrant} are both stored in
    * {@link DomainBase#allContacts} to allow for more efficient queries.
    */
@@ -101,10 +101,10 @@ public abstract class DomainBase extends EppResource {
 
   /**
    * A reference to the registrant who registered this domain.
-   * <p>
-   * This field is marked with {@literal @}Ignore so that {@link DomainBase} subclasses won't
-   * persist it. Instead, the data in this field and in the {@link DomainBase#contacts} are
-   * both stored in {@link DomainBase#allContacts} to allow for more efficient queries.
+   *
+   * <p>This field is marked with {@literal @}Ignore so that {@link DomainBase} subclasses won't
+   * persist it. Instead, the data in this field and in the {@link DomainBase#contacts} are both
+   * stored in {@link DomainBase#allContacts} to allow for more efficient queries.
    */
   @Ignore
   //TODO(b/28713909): Make this a Ref<ContactResource>.
@@ -115,8 +115,8 @@ public abstract class DomainBase extends EppResource {
 
   /**
    * Data used to construct DS records for this domain.
-   * <p>
-   * This is {@literal @}XmlTransient because it needs to be returned under the "extension" tag
+   *
+   * <p>This is {@literal @}XmlTransient because it needs to be returned under the "extension" tag
    * of an info response rather than inside the "infData" tag.
    */
   @XmlTransient

java/google/registry/model/domain/DomainCommand.java

@@ -445,9 +445,9 @@ public class DomainCommand {
 
     /**
      * Creates a copy of this {@link Update} with hard links to hosts and contacts.
-     * <p>
-     * As a side effect, this will turn null innerAdd/innerRemove/innerChange into empty versions of
-     * those classes, which is harmless because the getters do that anyways.
+     *
+     * <p>As a side effect, this will turn null innerAdd/innerRemove/innerChange into empty versions
+     * of those classes, which is harmless because the getters do that anyways.
      */
     @Override
     public Update cloneAndLinkReferences(DateTime now) throws InvalidReferencesException {

java/google/registry/model/domain/DomainResource.java

@@ -100,8 +100,8 @@ public class DomainResource extends DomainBase implements ForeignKeyedEppResourc
 
   /**
    * The poll message associated with this domain being deleted.
-   * <p>
-   * This field should be null if the domain is not in pending delete. If it is, the field should
+   *
+   * <p>This field should be null if the domain is not in pending delete. If it is, the field should
    * refer to a {@link PollMessage} timed to when the domain is fully deleted. If the domain is
    * restored, the message should be deleted.
    */
@@ -110,9 +110,9 @@ public class DomainResource extends DomainBase implements ForeignKeyedEppResourc
 
   /**
    * The recurring billing event associated with this domain's autorenewals.
-   * <p>
-   * The recurrence should be open ended unless the domain is in pending delete or fully deleted, in
-   * which case it should be closed at the time the delete was requested. Whenever the domain's
+   *
+   * <p>The recurrence should be open ended unless the domain is in pending delete or fully deleted,
+   * in which case it should be closed at the time the delete was requested. Whenever the domain's
    * {@link #registrationExpirationTime} is changed the recurrence should be closed, a new one
    * should be created, and this field should be updated to point to the new one.
    */
@@ -121,9 +121,9 @@ public class DomainResource extends DomainBase implements ForeignKeyedEppResourc
 
   /**
    * The recurring poll message associated with this domain's autorenewals.
-   * <p>
-   * The recurrence should be open ended unless the domain is in pending delete or fully deleted, in
-   * which case it should be closed at the time the delete was requested. Whenever the domain's
+   *
+   * <p>The recurrence should be open ended unless the domain is in pending delete or fully deleted,
+   * in which case it should be closed at the time the delete was requested. Whenever the domain's
    * {@link #registrationExpirationTime} is changed the recurrence should be closed, a new one
    * should be created, and this field should be updated to point to the new one.
    */
@@ -206,8 +206,8 @@ public class DomainResource extends DomainBase implements ForeignKeyedEppResourc
 
   /**
    * Returns the Registry Grace Period Statuses for this domain.
-   * <p>
-   * This collects all statuses from the domain's {@link GracePeriod}s and also adds the
+   *
+   * <p>This collects all statuses from the domain's {@link GracePeriod} entries and also adds the
    * PENDING_DELETE status if needed.
    */
   public ImmutableSet<GracePeriodStatus> getGracePeriodStatuses() {

java/google/registry/model/domain/GracePeriod.java

@@ -30,9 +30,9 @@ import javax.annotation.Nullable;
 
 /**
  * A domain grace period with an expiration time.
- * <p>
- * When a grace period expires, it is lazily removed from the {@link DomainResource} the next time
- * the resource is loaded from the datastore.
+ *
+ * <p>When a grace period expires, it is lazily removed from the {@link DomainResource} the next
+ * time the resource is loaded from the datastore.
  */
 @Embed
 public class GracePeriod extends ImmutableObject {

java/google/registry/model/domain/ReferenceUnion.java

@@ -28,8 +28,8 @@ import javax.xml.bind.annotation.adapters.XmlAdapter;
 /**
  * Legacy shell of a "union" type to represent referenced objects as either a foreign key or as a
  * link to another object in the datastore. In its current form it merely wraps a {@link Ref}.
- * <p>
- * This type always marshals as the "foreign key". We no longer use this type for unmarshalling.
+ *
+ * <p>This type always marshals as the "foreign key". We no longer use this type for unmarshalling.
  *
  * @param <T> the type being referenced
  */

java/google/registry/model/domain/allocate/AllocateCreateExtension.java

@@ -25,9 +25,9 @@ import javax.xml.bind.annotation.XmlRootElement;
 /**
  * An XML data object that represents an allocate extension that will be present on EPP commands to
  * allocate a domain from an application.
- * <p>
- * This object holds XML data which JAXB will unmarshal from an EPP domain create command extension.
- * The XML will have the following enclosing structure:
+ *
+ * <p>This object holds XML data which JAXB will unmarshal from an EPP domain create command
+ * extension.  The XML will have the following enclosing structure:
  *
  * <pre> {@code
  *   <epp>

java/google/registry/model/domain/fee/BaseFeeCommand.java

@@ -32,8 +32,8 @@ public class BaseFeeCommand extends ImmutableObject {
 
   /**
    * The magnitude of the fee, in the specified units, with an optional description.
-   * <p>
-   * This is a list because a single operation can involve multiple fees.
+   *
+   * <p>This is a list because a single operation can involve multiple fees.
    */
   @XmlElement(name = "fee")
   List<Fee> fees;

java/google/registry/model/domain/fee/BaseFeeCommandResponse.java

@@ -34,8 +34,8 @@ public class BaseFeeCommandResponse extends ImmutableObject {
 
   /**
    * The magnitude of the fee, in the specified units, with an optional description.
-   * <p>
-   * This is a list because a single operation can involve multiple fees.
+   *
+   * <p>This is a list because a single operation can involve multiple fees.
    */
   List<Fee> fee;
 

java/google/registry/model/domain/fee/BaseFeeResponse.java

@@ -43,15 +43,15 @@ public class BaseFeeResponse extends ImmutableObject {
 
   /**
    * The magnitude of the fee, in the specified units, with an optional description.
-   * <p>
-   * This is a list because a single operation can involve multiple fees.
+   *
+   * <p>This is a list because a single operation can involve multiple fees.
    */
   List<Fee> fee;
 
   /**
    * The type of the fee.
-   * <p>
-   * We will use "premium" for fees on premium names, and omit the field otherwise.
+   *
+   * <p>We will use "premium" for fees on premium names, and omit the field otherwise.
    */
   @XmlElement(name = "class")
   String feeClass;

java/google/registry/model/domain/fee/FeeDeleteResponseExtension.java

@@ -39,8 +39,8 @@ public class FeeDeleteResponseExtension extends ImmutableObject implements Respo
 
   /**
    * The magnitude of the credit(s), in the specified units, with an optional description.
-   * <p>
-   * This is a list because a single delete can receive multiple credits.
+   *
+   * <p>This is a list because a single delete can receive multiple credits.
    */
   @XmlElement(name = "credit")
   List<Credit> credits;

java/google/registry/model/domain/launch/ApplicationStatus.java

@@ -24,13 +24,13 @@ import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
 /**
  * Represents the EPP application status.
- * <p>
- * These values are never read from a command and only used in responses, so, we don't need to model
- * anything we don't output. We don't model the CUSTOM status because we don't use it. This allows
- * us to also avoid modeling the "name" attribute which is only used with CUSTOM. We don't model the
- * "lang" attribute because we only support English and that's the default.
- * <p>
- * Given all of this, we can use {@link EnumToAttributeAdapter} to make this code very simple.
+ *
+ * <p>These values are never read from a command and only used in responses, so, we don't need to
+ * model anything we don't output. We don't model the CUSTOM status because we don't use it. This
+ * allows us to also avoid modeling the "name" attribute which is only used with CUSTOM. We don't
+ * model the "lang" attribute because we only support English and that's the default.
+ *
+ * <p>Given all of this, we can use {@link EnumToAttributeAdapter} to make this code very simple.
  *
  * @see "http://tools.ietf.org/html/draft-tan-epp-launchphase-11#section-2.3"
  */

java/google/registry/model/domain/launch/LaunchCheckExtension.java

@@ -26,9 +26,9 @@ import javax.xml.bind.annotation.XmlRootElement;
 /**
  * An XML data object that represents a launch extension that may be present on EPP domain check
  * commands.
- * <p>
- * This object holds XML data which JAXB will unmarshal from an EPP domain check command extension.
- * The XML will have the following enclosing structure:
+ *
+ * <p>This object holds XML data which JAXB will unmarshal from an EPP domain check command
+ * extension.  The XML will have the following enclosing structure:
  *
  * <pre> {@code
  *   <epp>

java/google/registry/model/domain/launch/LaunchCreateExtension.java

@@ -34,9 +34,9 @@ import javax.xml.bind.annotation.XmlRootElement;
 /**
  * An XML data object that represents a launch extension that may be present on EPP domain create
  * commands.
- * <p>
- * This object holds XML data which JAXB will unmarshal from an EPP domain create command extension.
- * The XML will have the following enclosing structure:
+ *
+ * <p>This object holds XML data which JAXB will unmarshal from an EPP domain create command
+ * extension.  The XML will have the following enclosing structure:
  *
  * <pre> {@code
  *   <epp>

java/google/registry/model/domain/launch/LaunchPhase.java

@@ -34,8 +34,8 @@ import javax.xml.bind.annotation.XmlValue;
 
 /**
  * The launch phase of the TLD being addressed by this command.
- * <p>
- * The launch phase refers to the various stages that a TLD goes through before entering general
+ *
+ * <p>The launch phase refers to the various stages that a TLD goes through before entering general
  * availability. The various phases are described below (in order that they usually occur).
  */
 @Embed

java/google/registry/model/domain/secdns/SecDnsCreateExtension.java

@@ -32,8 +32,9 @@ import javax.xml.bind.annotation.XmlType;
 public class SecDnsCreateExtension extends ImmutableObject implements CommandExtension {
   /**
    * Time in seconds until the signature should expire.
-   * <p>
-   * We do not support expirations, but we need this field to be able to return appropriate errors.
+   *
+   * <p>We do not support expirations, but we need this field to be able to return appropriate
+   * errors.
    */
   Long maxSigLife;
 

java/google/registry/model/domain/secdns/SecDnsUpdateExtension.java

@@ -36,8 +36,8 @@ public class SecDnsUpdateExtension extends ImmutableObject implements CommandExt
 
   /**
    * Specifies whether this update is urgent.
-   * <p>
-   * We don't support urgent updates but we need this to be present to provide appropriate error
+   *
+   * <p>We don't support urgent updates but we need this to be present to provide appropriate error
    * messages if a client requests it.
    */
   @XmlAttribute
@@ -98,8 +98,8 @@ public class SecDnsUpdateExtension extends ImmutableObject implements CommandExt
   public static class Change extends ImmutableObject {
     /**
      * Time in seconds until the signature should expire.
-     * <p>
-     * We do not support expirations, but we need this field to be able to return appropriate
+     *
+     * <p>We do not support expirations, but we need this field to be able to return appropriate
      * errors.
      */
     Long maxSigLife;