mirror of
https://github.com/google/nomulus.git
synced 2025-05-20 11:19:35 +02:00
Make javadoc <p> style guide compliant
This led to confusion for an open source contributor about how to format code. We don't want to be like, "do as I say, not as I do." https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=122589700
This commit is contained in:
parent
4854f875b0
commit
6f4b059cc9
79 changed files with 395 additions and 386 deletions
|
@ -28,8 +28,8 @@ import javax.servlet.http.HttpServletResponse;
|
|||
/**
|
||||
* The {@link EppTlsServlet} class establishes a transport for EPP+TLS over* HTTP. All commands and
|
||||
* responses are EPP XML according to RFC 5730. Commands must must requested via POST.
|
||||
* <p>
|
||||
* There are a number of expected headers to this endpoint:
|
||||
*
|
||||
* <p>There are a number of expected headers to this endpoint:
|
||||
* <dl>
|
||||
* <dt>{@value #SSL_CLIENT_CERTIFICATE_HASH_FIELD}
|
||||
* <dd>
|
||||
|
|
|
@ -34,8 +34,9 @@ import java.util.Set;
|
|||
|
||||
/**
|
||||
* An abstract EPP flow.
|
||||
* <p>
|
||||
* This class also contains static methods for loading an appropriate flow based on model classes.
|
||||
*
|
||||
* <p>This class also contains static methods for loading an appropriate flow based on model
|
||||
* classes.
|
||||
*/
|
||||
public abstract class Flow {
|
||||
|
||||
|
|
|
@ -151,9 +151,9 @@ public class FlowRegistry {
|
|||
/**
|
||||
* The domain restore command is technically a domain {@literal <update>}, but logically a totally
|
||||
* separate flow.
|
||||
* <p>
|
||||
* This provider must be tried before {@link #RESOURCE_CRUD_FLOW_PROVIDER}. Otherwise, the regular
|
||||
* domain update flow will match first.
|
||||
*
|
||||
* <p>This provider must be tried before {@link #RESOURCE_CRUD_FLOW_PROVIDER}. Otherwise, the
|
||||
* regular domain update flow will match first.
|
||||
*/
|
||||
private static final FlowProvider DOMAIN_RESTORE_FLOW_PROVIDER = new FlowProvider() {
|
||||
@Override
|
||||
|
|
|
@ -144,18 +144,18 @@ public class FlowRunner {
|
|||
|
||||
/**
|
||||
* Helper for logging in json format.
|
||||
* <p>
|
||||
* This is needed because the usual json outputters perform normalizations that we don't want or
|
||||
* need, since we know that our values never need to be escaped - there are only strings and
|
||||
*
|
||||
* <p>This is needed because the usual json outputters perform normalizations that we don't want
|
||||
* or need, since we know that our values never need to be escaped - there are only strings and
|
||||
* numbers, and the strings are not allowed to contain quote characters.
|
||||
* <p>
|
||||
* An example output for an EPP_Mutation:
|
||||
* {"trid":"abc-123", "client":"some_registrar", "tld":"com", "xmlBytes":"abc123DEF"}
|
||||
* <p>
|
||||
* An example output for an EPP_Mutation_Committed that doesn't create a new resource:
|
||||
*
|
||||
* <p>An example output for an EPP_Mutation: {"trid":"abc-123", "client":"some_registrar",
|
||||
* "tld":"com", "xmlBytes":"abc123DEF"}
|
||||
*
|
||||
* <p>An example output for an EPP_Mutation_Committed that doesn't create a new resource:
|
||||
* {"trid":"abc-123", "executionTime":123456789}
|
||||
* <p>
|
||||
* An example output for an EPP_Mutation_Committed that creates a new resource:
|
||||
*
|
||||
* <p>An example output for an EPP_Mutation_Committed that creates a new resource:
|
||||
* {"trid":"abc-123", "executionRepoId":123, "executionTime":123456789}
|
||||
*/
|
||||
private static class JsonLogStatement {
|
||||
|
|
|
@ -86,9 +86,9 @@ public class ResourceFlowUtils {
|
|||
|
||||
/**
|
||||
* Create a pending action notification response indicating the resolution of a transfer.
|
||||
* <p>
|
||||
* The returned object will use the id and type of this resource, the trid of the resource's last
|
||||
* transfer request, and the specified status and date.
|
||||
*
|
||||
* <p>The returned object will use the id and type of this resource, the trid of the resource's
|
||||
* last transfer request, and the specified status and date.
|
||||
*/
|
||||
public static PendingActionNotificationResponse createPendingTransferNotificationResponse(
|
||||
EppResource eppResource,
|
||||
|
|
|
@ -16,8 +16,8 @@ package google.registry.flows;
|
|||
|
||||
/**
|
||||
* Marker interface indicating that a {@link Flow} needs to be run transactionally.
|
||||
* <p>
|
||||
* Any flow that mutates the datastore should be tagged with this so that {@link FlowRunner} will
|
||||
*
|
||||
* <p>Any flow that mutates the datastore should be tagged with this so that {@link FlowRunner} will
|
||||
* know how to run it.
|
||||
*/
|
||||
public interface TransactionalFlow {}
|
||||
|
|
|
@ -142,10 +142,10 @@ public abstract class BaseDomainCreateFlow<R extends DomainBase, B extends Build
|
|||
|
||||
/**
|
||||
* Fail the domain or application create very fast if the domain is already registered.
|
||||
* <p>
|
||||
* Try to load the domain non-transactionally, since this can hit memcache. If we succeed, and the
|
||||
* domain is not in the ADD grace period (the only state that allows instantaneous transition to
|
||||
* being deleted), we can assume that the domain will not be deleted (and therefore won't be
|
||||
*
|
||||
* <p>Try to load the domain non-transactionally, since this can hit memcache. If we succeed, and
|
||||
* the domain is not in the ADD grace period (the only state that allows instantaneous transition
|
||||
* to being deleted), we can assume that the domain will not be deleted (and therefore won't be
|
||||
* creatable) until its deletion time. For repeated failed creates this means we can avoid the
|
||||
* datastore lookup, which is very expensive (and first-seen failed creates are no worse than they
|
||||
* otherwise would be). This comes at the cost of the extra lookup for successful creates (or
|
||||
|
|
|
@ -47,8 +47,8 @@ import org.joda.time.DateTime;
|
|||
|
||||
/**
|
||||
* An EPP flow that approves a pending transfer on a {@link DomainResource}.
|
||||
* <p>
|
||||
* The logic in this flow, which handles client approvals, very closely parallels the logic in
|
||||
*
|
||||
* <p>The logic in this flow, which handles client approvals, very closely parallels the logic in
|
||||
* {@link DomainResource#cloneProjectedAtTime} which handles implicit server approvals.
|
||||
*
|
||||
* @error {@link google.registry.flows.domain.DomainFlowUtils.NotAuthorizedForTldException}
|
||||
|
|
|
@ -184,10 +184,10 @@ public class DomainTransferRequestFlow
|
|||
/**
|
||||
* When a transfer is requested, schedule a billing event and poll message for the automatic
|
||||
* approval case.
|
||||
* <p>
|
||||
* Note that the action time is AUTOMATIC_TRANSFER_DAYS in the future, matching the server policy
|
||||
* on automated approval of transfers. There is no equivalent grace period added; if the transfer
|
||||
* is implicitly approved, the resource will project a grace period on itself.
|
||||
*
|
||||
* <p>Note that the action time is AUTOMATIC_TRANSFER_DAYS in the future, matching the server
|
||||
* policy on automated approval of transfers. There is no equivalent grace period added; if the
|
||||
* transfer is implicitly approved, the resource will project a grace period on itself.
|
||||
*/
|
||||
@Override
|
||||
protected Set<Key<? extends TransferServerApproveEntity>> getTransferServerApproveEntities() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue