zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-30 03:57:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Show HTTP response code when PUT fails (#2038)

Browse source
This commit is contained in:
Lai Jiang 2023-05-23 17:01:56 -04:00 • committed by GitHub
parent 0965839055
commit 6eb5ff3cbb
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
core/src/main/java/google/registry/rde/RdeReporter.java
View file

@ -43,6 +43,7 @@ import java.io.ByteArrayInputStream;
import java.net.MalformedURLException; import java.net.MalformedURLException;
import java.net.SocketTimeoutException; import java.net.SocketTimeoutException;
import java.net.URL; import java.net.URL;
import java.util.Arrays;
import javax.inject.Inject; import javax.inject.Inject;
/** /**
@ -86,22 +87,23 @@ public class RdeReporter {
retrier.callWithRetry( retrier.callWithRetry(
() -> { () -> {
HTTPResponse rsp1 = urlFetchService.fetch(req); HTTPResponse rsp1 = urlFetchService.fetch(req);
switch (rsp1.getResponseCode()) { int responseCode = rsp1.getResponseCode();
case SC_OK: if (responseCode != SC_OK && responseCode != SC_BAD_REQUEST) {
case SC_BAD_REQUEST: logger.atSevere().log(
break; "Failure when trying to PUT RDE report to ICANN server: %d\n%s",
default: responseCode, Arrays.toString(rsp1.getContent()));
throw new RuntimeException("PUT failed"); throw new RuntimeException("Error uploading deposits to ICANN");
} }
return rsp1; return rsp1;
}, },
SocketTimeoutException.class); SocketTimeoutException.class);
// Ensure the XML response is valid. // Ensure the XML response is valid. The EPP result code would not be 1000 if we get an
// SC_BAD_REQUEST as the HTTP response code.
XjcIirdeaResult result = parseResult(rsp.getContent()); XjcIirdeaResult result = parseResult(rsp.getContent());
if (result.getCode().getValue() != 1000) { if (result.getCode().getValue() != 1000) {
logger.atWarning().log( logger.atWarning().log(
"PUT rejected: %d %s\n%s", "Rejected when trying to PUT RDE report to ICANN server: %d %s\n%s",
result.getCode().getValue(), result.getMsg(), result.getDescription()); result.getCode().getValue(), result.getMsg(), result.getDescription());
throw new InternalServerErrorException(result.getMsg()); throw new InternalServerErrorException(result.getMsg());
} }