Convert more flow tests to replay/compare (#1009)

* Convert more flow tests to replay/compare

Add the replay extension to another batch of flow tests.  In the course of
this:

- Refactor out domain deletion code into DatabaseHelper so that it can be used
  from multiple tests.
- Make null handling uniform for contact phone numbers.

* Convert postLoad method to onLoad.

* Remove "Test" import missed during rebase

* Deal with persistence of billing cancellations

Deal with the persistence of billing cancellations, which were added in the
master branch since before this PR was initially sent for review.

* Adding forgotten flyway file

* Removed debug variable

db/src/main/resources/sql/er_diagram/brief_er_diagram.html

@@ -261,11 +261,11 @@ td.section {
     </tr> 
     <tr> 
      <td class="property_name">generated on</td> 
-     <td class="property_value">2021-03-04 16:08:40.773463</td> 
+     <td class="property_value">2021-03-16 19:06:44.592583</td> 
     </tr> 
     <tr>
      <td class="property_name">last flyway file</td>
-     <td id="lastFlywayFile" class="property_value">V87__fix_super_domain_fk.sql</td>
+     <td id="lastFlywayFile" class="property_value">V88__transfer_billing_cancellation_history_id.sql</td>
     </tr>
    </tbody>
   </table> 
@@ -284,7 +284,7 @@ td.section {
      generated on
     </text> 
     <text text-anchor="start" x="4027.94" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">
-     2021-03-04 16:08:40.773463
+     2021-03-16 19:06:44.592583
     </text> 
     <polygon fill="none" stroke="#888888" points="3940.44,-4 3940.44,-44 4205.44,-44 4205.44,-4 3940.44,-4" /> <!-- allocationtoken_a08ccbef --> 
     <g id="node1" class="node"> 

db/src/main/resources/sql/flyway.txt

@@ -85,3 +85,4 @@ V84__add_vkey_columns_in_billing_cancellation.sql
 V85__add_required_columns_in_transfer_data.sql
 V86__third_poll_message.sql
 V87__fix_super_domain_fk.sql
+V88__transfer_billing_cancellation_history_id.sql

db/src/main/resources/sql/flyway/V88__transfer_billing_cancellation_history_id.sql

@@ -0,0 +1,18 @@
+-- Copyright 2021 The Nomulus Authors. All Rights Reserved.
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+ALTER TABLE "Domain"
+    ADD COLUMN  "transfer_billing_cancellation_history_id" int8;
+ALTER TABLE "DomainHistory"
+    ADD COLUMN  "transfer_billing_cancellation_history_id" int8;

db/src/main/resources/sql/schema/db-schema.sql.generated

@@ -280,6 +280,7 @@
         subordinate_hosts text[],
         tech_contact text,
         tld text,
+        transfer_billing_cancellation_history_id int8,
         transfer_billing_cancellation_id int8,
         transfer_billing_recurrence_id int8,
         transfer_billing_recurrence_history_id int8,
@@ -352,6 +353,7 @@
         subordinate_hosts text[],
         tech_contact text,
         tld text,
+        transfer_billing_cancellation_history_id int8,
         transfer_billing_cancellation_id int8,
         transfer_billing_recurrence_id int8,
         transfer_billing_recurrence_history_id int8,

db/src/main/resources/sql/schema/nomulus.golden.sql

@@ -386,7 +386,8 @@ CREATE TABLE public."Domain" (
     transfer_billing_event_history_id bigint,
     transfer_history_entry_id bigint,
     transfer_repo_id text,
-    transfer_poll_message_id_3 bigint
+    transfer_poll_message_id_3 bigint,
+    transfer_billing_cancellation_history_id bigint
 );
 
 
@@ -477,7 +478,8 @@ CREATE TABLE public."DomainHistory" (
     transfer_billing_event_history_id bigint,
     transfer_history_entry_id bigint,
     transfer_repo_id text,
-    transfer_poll_message_id_3 bigint
+    transfer_poll_message_id_3 bigint,
+    transfer_billing_cancellation_history_id bigint
 );