zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-04 00:42:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove 'fullyQualified' from host and domain names (#631)

Browse source 
* Remove 'fullyQualified' from host and domain names

We don't actually enforce that these are properly fully-qualified
(there's no dot at the end) and we specifically use the term "label
name" when talking about labels.

Note: this doesn't convert FQDN -> DN (et al) in at least two types of
cases:
1. When the term is part of the XML schema
2. When the term is used by some external system, e.g. SafeBrowsing API

* Add TODO to rename fields
This commit is contained in:
gbrodman 2020-06-17 16:19:26 -04:00 • committed by GitHub
parent 19395def5b
commit 69a1d04c18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
87 changed files with 245 additions and 228 deletions
Download patch file Download diff file Expand all files Collapse all files

17
db/src/main/resources/sql/flyway/V34__rename_fully_qualified_names.sql Normal file
View file

@ -0,0 +1,17 @@
-- Copyright 2020 The Nomulus Authors. All Rights Reserved.
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
ALTER TABLE "Domain" RENAME COLUMN "fully_qualified_domain_name" TO "domain_name";
ALTER TABLE "HostResource" RENAME COLUMN "fully_qualified_host_name" TO "host_name";
ALTER TABLE "HostHistory" RENAME COLUMN "fully_qualified_host_name" TO "host_name";

10
db/src/main/resources/sql/schema/db-schema.sql.generated
View file

@ -162,7 +162,7 @@ create sequence history_id_sequence start 1 increment 1;
auth_info_repo_id text,
auth_info_value text,
billing_contact text,
fully_qualified_domain_name text,
domain_name text,
idn_table_name text,
last_transfer_time timestamptz,
launch_notice_accepted_time timestamptz,
@ -220,7 +220,7 @@ create sequence history_id_sequence start 1 increment 1;
history_server_transaction_id text,
history_type text not null,
history_xml_bytes bytea not null,
fully_qualified_host_name text,
host_name text,
inet_addresses text[],
last_superordinate_change timestamptz,
last_transfer_time timestamptz,
@ -245,7 +245,7 @@ create sequence history_id_sequence start 1 increment 1;
last_epp_update_registrar_id text,
last_epp_update_time timestamptz,
statuses text[],
fully_qualified_host_name text,
host_name text,
inet_addresses text[],
last_superordinate_change timestamptz,
last_transfer_time timestamptz,
@ -429,11 +429,11 @@ create index IDX1p3esngcwwu6hstyua6itn6ff on "Contact" (search_name);
create index IDX8nr0ke9mrrx4ewj6pd2ag4rmr on "Domain" (creation_time);
create index IDXhsjqiy2lyobfymplb28nm74lm on "Domain" (current_sponsor_registrar_id);
create index IDX5mnf0wn20tno4b9do88j61klr on "Domain" (deletion_time);
create index IDX1rcgkdd777bpvj0r94sltwd5y on "Domain" (fully_qualified_domain_name);
create index IDXc5aw4pk1vkd6ymhvkpanmoadv on "Domain" (domain_name);
create index IDXrwl38wwkli1j7gkvtywi9jokq on "Domain" (tld);
create index IDXfg2nnjlujxo6cb9fha971bq2n on "HostHistory" (creation_time);
create index IDX1iy7njgb7wjmj9piml4l2g0qi on "HostHistory" (history_registrar_id);
create index IDXj77pfwhui9f0i7wjq6lmibovj on "HostHistory" (fully_qualified_host_name);
create index IDXkkwbwcwvrdkkqothkiye4jiff on "HostHistory" (host_name);
create index IDXknk8gmj7s47q56cwpa6rmpt5l on "HostHistory" (history_type);
create index IDX67qwkjtlq5q8dv6egtrtnhqi7 on "HostHistory" (history_modification_time);
create index IDXe7wu46c7wpvfmfnj4565abibp on "PollMessage" (registrar_id);

10
db/src/main/resources/sql/schema/nomulus.golden.sql
View file

@ -281,7 +281,7 @@ CREATE TABLE public."Domain" (
statuses text[],
auth_info_repo_id text,
auth_info_value text,
fully_qualified_domain_name text,
domain_name text,
idn_table_name text,
last_transfer_time timestamp with time zone,
launch_notice_accepted_time timestamp with time zone,
@ -352,7 +352,7 @@ CREATE TABLE public."HostHistory" (
history_server_transaction_id text,
history_type text NOT NULL,
history_xml_bytes bytea NOT NULL,
fully_qualified_host_name text,
host_name text,
inet_addresses text[],
last_superordinate_change timestamp with time zone,
last_transfer_time timestamp with time zone,
@ -381,7 +381,7 @@ CREATE TABLE public."HostResource" (
last_epp_update_registrar_id text,
last_epp_update_time timestamp with time zone,
statuses text[],
fully_qualified_host_name text,
host_name text,
last_superordinate_change timestamp with time zone,
last_transfer_time timestamp with time zone,
superordinate_domain text,
@ -898,7 +898,7 @@ CREATE INDEX idx1p3esngcwwu6hstyua6itn6ff ON public."Contact" USING btree (searc
-- Name: idx1rcgkdd777bpvj0r94sltwd5y; Type: INDEX; Schema: public; Owner: -
--
CREATE INDEX idx1rcgkdd777bpvj0r94sltwd5y ON public."Domain" USING btree (fully_qualified_domain_name);
CREATE INDEX idx1rcgkdd777bpvj0r94sltwd5y ON public."Domain" USING btree (domain_name);
--
@ -1024,7 +1024,7 @@ CREATE INDEX idxhmv411mdqo5ibn4vy7ykxpmlv ON public."BillingEvent" USING btree (
-- Name: idxj77pfwhui9f0i7wjq6lmibovj; Type: INDEX; Schema: public; Owner: -
--
CREATE INDEX idxj77pfwhui9f0i7wjq6lmibovj ON public."HostHistory" USING btree (fully_qualified_host_name);
CREATE INDEX idxj77pfwhui9f0i7wjq6lmibovj ON public."HostHistory" USING btree (host_name);
--