zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 00:47:11 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clean up misc Javadoc and deprecation warnings

Browse source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136156922
This commit is contained in:
ctingue 2016-10-14 07:56:22 -07:00 • committed by Ben McIlwain
parent 064026a4a5
commit 67da55536f
4 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
java/google/registry/monitoring/metrics/MetricMetrics.java
View file

@ -49,6 +49,7 @@ final class MetricMetrics {
LABELS); LABELS);
/** A gauge representing a snapshot of the number of active timeseries being reported. */ /** A gauge representing a snapshot of the number of active timeseries being reported. */
@SuppressWarnings("unused")
private static final Metric<Long> timeseriesCount = private static final Metric<Long> timeseriesCount =
MetricRegistryImpl.getDefault() MetricRegistryImpl.getDefault()
.newGauge( .newGauge(

3
java/google/registry/rde/RdeImportUtils.java
View file

@ -135,8 +135,7 @@ public class RdeImportUtils {
// TODO (wolfgang): Add validation method for IDN tables // TODO (wolfgang): Add validation method for IDN tables
try (InputStream input = try (InputStream input =
gcsUtils.openInputStream(new GcsFilename(escrowBucketName, escrowFilePath))) { gcsUtils.openInputStream(new GcsFilename(escrowBucketName, escrowFilePath))) {
try { try (RdeParser parser = new RdeParser(input)) {
RdeParser parser = new RdeParser(input);
// validate that tld exists and is in PREDELEGATION state // validate that tld exists and is in PREDELEGATION state
String tld = parser.getHeader().getTld(); String tld = parser.getHeader().getTld();
try { try {

10
javatests/google/registry/testing/AbstractEppResourceSubject.java
View file

@ -106,7 +106,7 @@ abstract class AbstractEppResourceSubject
public HistoryEntrySubject hasOnlyOneHistoryEntryWhich() { public HistoryEntrySubject hasOnlyOneHistoryEntryWhich() {
hasOnlyOneHistoryEntry(); hasOnlyOneHistoryEntry();
return assertAboutHistoryEntries().that(getHistoryEntries().get(0)).withCustomDisplaySubject( return assertAboutHistoryEntries().that(getHistoryEntries().get(0)).withCustomDisplaySubject(
"the only history entry for " + getDisplaySubject()); "the only history entry for " + actualAsString());
} }
public Which<HistoryEntrySubject> hasHistoryEntryAtIndex(int index) { public Which<HistoryEntrySubject> hasHistoryEntryAtIndex(int index) {
@ -117,12 +117,12 @@ abstract class AbstractEppResourceSubject
} }
return new Which<>(assertAboutHistoryEntries() return new Which<>(assertAboutHistoryEntries()
.that(getHistoryEntries().get(index)).withCustomDisplaySubject(String.format( .that(getHistoryEntries().get(index)).withCustomDisplaySubject(String.format(
"the history entry for %s at index %s", getDisplaySubject(), index))); "the history entry for %s at index %s", actualAsString(), index)));
} }
public And<S> hasStatusValue(StatusValue statusValue) { public And<S> hasStatusValue(StatusValue statusValue) {
if (!actual().getStatusValues().contains(statusValue)) { if (!actual().getStatusValues().contains(statusValue)) {
failWithRawMessage("%s should have had status value %s", getDisplaySubject(), statusValue); failWithRawMessage("%s should have had status value %s", actualAsString(), statusValue);
} }
return andChainer(); return andChainer();
} }
@ -130,7 +130,7 @@ abstract class AbstractEppResourceSubject
public And<S> doesNotHaveStatusValue(StatusValue statusValue) { public And<S> doesNotHaveStatusValue(StatusValue statusValue) {
if (actual().getStatusValues().contains(statusValue)) { if (actual().getStatusValues().contains(statusValue)) {
failWithRawMessage( failWithRawMessage(
"%s should not have had status value %s", getDisplaySubject(), statusValue); "%s should not have had status value %s", actualAsString(), statusValue);
} }
return andChainer(); return andChainer();
} }
@ -138,7 +138,7 @@ abstract class AbstractEppResourceSubject
public And<S> hasExactlyStatusValues(StatusValue... statusValues) { public And<S> hasExactlyStatusValues(StatusValue... statusValues) {
if (!ImmutableSet.copyOf(actual().getStatusValues()) if (!ImmutableSet.copyOf(actual().getStatusValues())
.equals(ImmutableSet.copyOf(statusValues))) { .equals(ImmutableSet.copyOf(statusValues))) {
assertThat(actual().getStatusValues()).named("status values for " + getDisplaySubject()) assertThat(actual().getStatusValues()).named("status values for " + actualAsString())
.containsExactly((Object[]) statusValues); .containsExactly((Object[]) statusValues);
} }
return andChainer(); return andChainer();

2
javatests/google/registry/testing/DomainApplicationSubject.java
View file

@ -54,7 +54,7 @@ public final class DomainApplicationSubject
ImmutableSet.copyOf(actual().getEncodedSignedMarks()), ImmutableSet.copyOf(actual().getEncodedSignedMarks()),
ImmutableSet.of(encodedSignedMarks))) { ImmutableSet.of(encodedSignedMarks))) {
assertThat(actual().getEncodedSignedMarks()) assertThat(actual().getEncodedSignedMarks())
.named("the encoded signed marks of " + getDisplaySubject()) .named("the encoded signed marks of " + actualAsString())
.containsExactly((Object[]) encodedSignedMarks); .containsExactly((Object[]) encodedSignedMarks);
} }
return andChainer(); return andChainer();