zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-21 02:06:00 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add SQL queries to RdapNameserverSearchAction (#987)

Browse source 
This has the same issue as the domain-search action where the database
ordering is not consistent between Objectify and SQL -- as a result,
there is one test that we have to duplicate in order to account for the
two sort orders.

In addition, there isn't a way to query @Convert-ed fields in Postgres
via the standard Hibernate / JPA query language, meaning we have to use
a raw Postgres query for that.
This commit is contained in:
gbrodman 2021-03-22 12:33:11 -04:00 • committed by GitHub
parent 0b6a5aec96
commit 67d767bd68
5 changed files with 198 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

1
config/presubmits.py
View file

@ -211,6 +211,7 @@ PRESUBMITS = {
# CriteriaQueryBuilder is a false positive
"CriteriaQueryBuilder.java",
"RdapDomainSearchAction.java",
"RdapNameserverSearchAction.java",
"RdapSearchActionBase.java",
},
):